Bug 16016 - Radio "when stopped" screensaver "none" choice no longer works
: Radio "when stopped" screensaver "none" choice no longer works
Status: RESOLVED FIXED
Product: SB Radio
Classification: Unclassified
Component: Screensavers
: Include FW version in comment
: PC Other
: -- critical (vote)
: ---
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-07 10:37 UTC by Wadzinski Tom
Modified: 2010-05-24 13:30 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wadzinski Tom 2010-04-07 10:37:03 UTC
Version 7.5 r8763 (affects all devices, I suspect, not just radio).
Under the new 7.5.0 release, if you set the "when stopped" screensaver to none, a clock screensaver will still appear. 

I marked this as critical because "none" is the default for "when stopped" on radio, so the default behavior for radio has essentially changed and users can't change it back.

Below is a suggested fix, basically revert the old "skip ss code" and move the time check code later.

Current:
	if not screensaver or not screensaver.applet or
		( tonumber(year) < 2009 and not force and self:_getMode() == 'whenOff' ) then -- fallback to blank screensaver on whenOff and no clock
		-- no screensaver, fallback to default
		log:warn('The configured screensaver method ', the_screensaver, ' is not available. Falling back to default from Meta file')
		local fallbackKey = self.defaultSettings[self:_getMode()]
		screensaver = self.screensavers[fallbackKey]
	--	return
	end


Suggested fix:

	--The "none" choice give false:false, for that case, just return
	if not screensaver or not screensaver.applet then
		-- no screensaver, do nothing
		return
	end

	if ( tonumber(year) < 2009 and not force and self:_getMode() == 'whenOff' ) then -- fallback to blank screensaver on whenOff and no clock
		log:warn('The configured screensaver method ', the_screensaver, ' is not available. Falling back to default from Meta file')
		local fallbackKey = self.defaultSettings[self:_getMode()]
		screensaver = self.screensavers[fallbackKey]
	--	return
	end
Comment 1 Jim McAtee 2010-04-07 13:47:07 UTC
Same on the Touch and also in the SqueezePlay software player.  Getting the digital clock (on gray background) when the stopped screensaver is set to 'None'.
Comment 2 Jim McAtee 2010-04-11 01:04:03 UTC
This is a duplicate of bug 15667.
Comment 3 Michael Herger 2010-04-12 02:12:15 UTC

*** This bug has been marked as a duplicate of bug 15667 ***
Comment 4 Spies Steven 2010-04-12 08:28:43 UTC
I believe this bug is also a duplicate of bug 15873.
Comment 5 SVN Bot 2010-04-12 13:24:07 UTC
 == Auto-comment from SVN commit #8691 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8691 ==

Fixed Bug: 16016
Description: allow screensaver of "none" to work while still allowing a fallback SS for situations where the configured SS has gone away (e.g., a third party applet no longer installed)
Comment 6 Ben Klaas 2010-05-24 13:30:36 UTC
*** Bug 16257 has been marked as a duplicate of this bug. ***