Bugzilla – Bug 16000
Extras menu must be added if plugin is adding menu item
Last modified: 2011-11-06 23:24:43 UTC
I experienced this when trying Michael's Photo Gallery plugin, but I'm filing a bug because I'm guessing that this is a limitation of the SbS plugin framework and not just Michael's plugin. If I'm wrong, just close this. When Photo Gallery is installed, the Extras menu item is only visible when the Touch is controlling itself. So if I'm using the Touch to control another player, I must change players to view my photos and then change players back to control audio on another player. This is even more of an inconvenience on the Controller since, in many setups, it is rarely controlling itself.
I might be wrong, but the Extras menu doesn't show up automatically. Or it only does so on new players. You'll have to enable it in Settings/Home menu. This _might_ be necessary for every player your control. I'm using Controller to control my Transporter most of the time. The plugin is showing up there and working fine. How did you find out about the plugin anyway? You should run it on 7.6 for best results ;-).
Hi Michael, I'm running 7.6 with r8672 on all SP-based devices. AFAICT, Settings->Home Menu only contains entries for items that are available somewhere else in the menu structure and Extras is not one of them. This could still be user error on my part, but I don't know where else to look for it.. BTW, I noticed the plugin because it is the only one of yours that shows up under 7.6. You need to bump maxVersion for your others. It works well otherwise, BTW, on slow server hardware (Sheevaplug).
OK, the bug is a bit different but has a workaround. 1) Install Picture Gallery while the SBC is controller some other player 2) Note that extras is not in the SBC menus and cannot be added 3) Switch players on the SBC to itself 4) Notice that Extras->Picture Gallery is there on the SBC and works 5) Switch players back to some other player 6) Notice that Extras->Picture Gallery is still there on the SBC and works So, something automatic needs to happen when a plugin is added while SP-based devices are not controlling themselves.
Thanks for the heads up about the maxTarget. It was set to 7.5+ - which I expected to be working fine. As for this bug: can we change it to title something like "Extras menu must be added if plugin is adding menu item" or similar? I guess any re-connect to that server would probably do the update, but it doesn't happen if it's "connected" while you restart the server?
Title changed. I'm not really sure what constitute a "server re-connect" but I'll see if I can find any other user actions that cause the menu items to be added.
This bug and it's workaround could be more clearly stated as: Bug: By default, Extras is not in the home menu (and cannot be added) for any SP-based player. Workaround: Change player one or more times. Note that a side effect of this is that the Info Browser (installed by default) is not accessible on any SP-based player until the player is changed at least once.
A target of 7.6.0 seems reasonable given the team's interest in improving the plugin architecture. Please let me know if anyone feels otherwise. Michael, shall I go ahead and assign this to you?
I'd like to see Ben's input first, as I guess he'll already know why this is.
It's an odd one, extras. I've never known it to behave the way I would think it should. It's clearly added as a node in JiveMain, which means it should be magically appear whenever any items are added to the node, as well as magically disappear when the node is without any submenu items. It's in this "magic" that I'm guessing the bug resides. jive/JiveMain.lua 462: jiveMain:addNode( { id = 'extras', node = 'home', text = _globalStrings:str("EXTRAS"), weight = 50, hiddenWeight = 91 } )
Unassigned bugs cannot have a priority.