Bug 15946 - Ejecting USB immediately after attaching USB drive jumps back to Important Notice screen
: Ejecting USB immediately after attaching USB drive jumps back to Important No...
Status: CLOSED FIXED
Product: SB Touch
Classification: Unclassified
Component: TinySC
: 7.5.0
: PC Windows XP
: P1 normal (vote)
: 7.5.0
Assigned To: Felix Mueller
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-24 10:09 UTC by Mickey Gee
Modified: 2010-04-08 17:26 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments
patch to remove buried device eject warning window after device is ejected (1020 bytes, patch)
2010-03-25 15:29 UTC, Ben Klaas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mickey Gee 2010-03-24 10:09:49 UTC
Using firmware r8665, I'm attaching external USB drives of 1.5TB and 1TB in size. Both drives attach OK.

If I try to eject the USB drive immediately after it starts scanning the drive, the IMPORTANT NOTICE screen comes up after the eject completes successfully instead of returning to the home menu.

This is reproducible every time with these drives. Here's my sequence:

1. Attach USB drive.
2. Attaching USB Device screen appears
3. Starting Squeezebox Server screen appears
4. IMPORTANT NOTICE screen appears (OK)
5. Immediately choose Eject USB Device option from IMPORTANT NOTICE screen.
6. Choose Eject USB Device from Eject USB Device? screen.
7. Ejecting USB Device screen appears.
8. Device Ejected screen. Press OK to continue.
9. IMPORTANT NOTICE screen appears. Not OK. Should go to Home menu.
10. Selecting Eject USB Device option on this screen does nothing except beep.

Going to Home Menu shows normal menu without Eject USB option.
Comment 1 Mickey Gee 2010-03-24 10:10:41 UTC
Have pics, but probably not needed.
Comment 2 Chris Owens 2010-03-25 09:37:19 UTC
If possible the second 'Important Notice' screen should not appear.  Regardless, the screen should have a 'back' button to get out of it, since the 'home' swipe gesture is not well-documented.

Assigning to Ben first, if he doesn't get it done, please assign to Felix.
Comment 3 Ben Klaas 2010-03-25 15:29:32 UTC
Created attachment 6704 [details]
patch to remove buried device eject warning window after device is ejected

save the initial device eject window to self.ejectWarningWindow

when device is ejected through either responsible or irresponsible means, hide this window if it exists
Comment 4 Ben Klaas 2010-03-25 15:30:17 UTC
Felix, I think the patch is pretty low risk and has been tested as working. Could you review and test yourself. If it passes, go ahead and check it in.
Comment 5 SVN Bot 2010-03-26 11:47:33 UTC
 == Auto-comment from SVN commit #8669 to the jive repo by fmueller ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8669 ==

Bug: 15946 
Description: Fix to remove buried device eject warning window after device is ejected
Comment 6 Chris Owens 2010-04-08 17:26:33 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!