Bugzilla – Bug 15910
Alarm screensaver setting does not work
Last modified: 2011-03-16 04:45:48 UTC
Whether set on the device or using SB Server, the setting "RSS News Ticker" does not work as a screensaver when alarm is playing. It appears that the setting for "Screensaver when playing" is used instead.
There's no alarm screensaver setting available (yet). I thought there was such an enhancement request already, but can't find it.
Michael notes that we need a way to make the RSS screensaver not show up in the preferences list.
This actually is a regression and is not related to the RSS reader: the setting is simply ignored.
We need to pass the $client along to the alarmScreensaver() function, or it won't be able to read the saver pref: Index: server/Slim/Utils/Alarm.pm =================================================================== --- server/Slim/Utils/Alarm.pm (revision 30411) +++ server/Slim/Utils/Alarm.pm (working copy) @@ -1833,7 +1833,7 @@ my $client = shift; my $currentMode = Slim::Buttons::Common::mode($client); - my $alarmScreensaver = $class->alarmScreensaver; + my $alarmScreensaver = $class->alarmScreensaver($client); if ($client->display->isa('Slim::Display::NoDisplay')) { $alarmScreensaver = undef; } @@ -1864,7 +1864,7 @@ my $currentMode = Slim::Buttons::Common::mode($client); main::DEBUGLOG && $log->debug("Attempting to pop alarm screensaver. Current mode: $currentMode"); - if ($currentMode eq $class->alarmScreensaver) { + if ($currentMode eq $class->alarmScreensaver($client)) { main::DEBUGLOG && $log->debug('Popping alarm screensaver'); Slim::Buttons::Common::popMode($client); }
== Auto-comment from SVN commit #30426 to the slim repo by mherger == == https://svn.slimdevices.com/slim?view=revision&revision=30426 == Fixed Bug: 15910 Description: We need to pass the $client along to the alarmScreensaver() function, or it won't be able to read the saver pref.
Fix verified in r30438.