Bug 1590 – songinfo.xml does not return correct information

Bug 1590 - songinfo.xml does not return correct information

Summary:

songinfo.xml does not return correct information

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	XML
Version:	6.0.3
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-05-20 00:37 UTC by Malcolm Green
Modified:	2008-09-15 14:37 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
patch for above (450 bytes, patch) 2005-05-20 10:27 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Malcolm Green 2005-05-20 00:37:54 UTC

With 6.0.2 and prior versions, the URL
http://myserver:9000/xml/songinfo.xml?item=n returns full tag information for
the specified item.  In 6.0.3 (SlimServer_v2005-05-19.exe), the same URL returns
only a truncated comment tag.  This breaks our application TelCanto for
SlimServer which depends on the XML interface.

Comment 1 KDF 2005-05-20 10:26:34 UTC

I think this stems from a fix for bug 1484.  The itemObj is not used
consistently.  songinfo by itself seems to use 'track' as the object, while the
status header uses 'itemObj'.  XML skin seems to use _xml_song for both.

The simple fix would be to add:
$params->{'itemobj'} = $track unless $params->{'itemobj'};

at Pages.pm line 1876, but a more complete fix would be to pick move everything
to a more consistent object.  'track', 'trackobj' or 'itemobj' throughout.

Comment 2 KDF 2005-05-20 10:27:54 UTC

Created attachment 521 [details]
patch for above

here is the patch to do jsut as I had described for the simple fix.  Hopefully
Dan will commit this as I'll be on a plane to the UK shortly.

Comment 3 Dan Sully 2005-05-22 12:07:59 UTC

I've commited kdf's patch as subversion change 3279.

Comment 4 Chris Owens 2006-06-16 14:41:17 UTC

There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.