Bugzilla – Bug 15854
You can exit "Mounting..." spinny, causing SP _not_ to add the "Unmount" item
Last modified: 2010-04-08 17:24:50 UTC
- plug in media - touch the "Mounting..." screen -> you're sent back to the main menu -> no "Unmount..." item is added to the main menu I think the issue is that the menu item is added at the end of the spinny (when the task finishes it's regular time running), but not if it's exited prematurely. We either need to make the screen non-exitable, or add the menu item while the spinny is up, and not when it's regularly closed.
Created attachment 6631 [details] patch to make mounting drive not escapable and eject item added to home menu before tinySC starts - add a framework listener to consume all input when mounting popup comes to the screen - disable screensavers during this popup - turn autohide off for popup - make popup always on top of stack - reduce mounting timeout to 20 seconds - remove framework listener when popup leaves screen, either due to mount failure or mount success - add the eject item to the home menu before SC starts up
the following tests should be run after this patch is applied: test a: add usb drive after fab4 is running try to escape the "Attaching USB" spinny through any means of input possible (IR remote, touching screen, etc.) verify that this spinny cannot be exited test b: after usb is attached, tinySC should startup and another spinny hits the screen exit this spinny by touching the screen (this popup _should_ be exitable) press back-hold on the left arrow button to go to the home menu verify there is an eject usb item and that it works
Patch to fix is applied. I've done all I'm going to do on this bug, it's QA's call on whether to include the fix with 7.5.0
sorry, that should say "patch to fix is attached to this bug". nothing has been applied to the code :)
Ben - FYI: There is a simpler solution to make a spinny non exitable. popup:ignoreAllInputExcept() Felix
Created attachment 6632 [details] cleaner patch to make popup not escapable Thanks Felix. Cleaned up the patch to use popup:ignoreAllInputExcept() I tested this and it works as desired. This is probably a safer patch because it does not involve the add/remove of a Framework listener.
== Auto-comment from SVN commit #8653 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=8653 == Fixed Bug: 15854 - ignore all input when "attaching" popup is on screen - disable screensavers during this popup - turn autohide off for popup - make popup always on top of stack - reduce mounting timeout to 20 seconds - add the eject item to the home menu before SC starts up
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release. If you are still seeing this issue, please let us know!