Bug 15841 - DeleteFile error when upgrading from 7.4.2 to 7.5.0
: DeleteFile error when upgrading from 7.4.2 to 7.5.0
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Windows Installer
: 7.5.x
: PC Windows Vista
: P3 normal with 1 vote (vote)
: 7.5.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-05 13:53 UTC by Cory Nielsen
Modified: 2010-04-01 15:23 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cory Nielsen 2010-03-05 13:53:56 UTC
While upgrading SBS from 7.4.2 to 7.5.0, I get the following error message:

C:\Program Files (x86)\Squeezebox\SqueezeTray.exe

An error occurred while trying to replace the existing file:
DeleteFile failed; code 5.
Access is denied.

When I click Retry, the upgrade appears to proceed normally without any further issues.
Comment 1 Michael Herger 2010-03-05 22:36:04 UTC
This imho is not a bug, but some timing issue: the installer is waiting a finite amount of seconds for the tray icon (and other components) to be stopped before it continues. If the system for whatever reason take a bit longer, you're given that option to try again - which obviously is working as expected in your case. 

Does this always happen for you, or only this time?
Comment 2 Cory Nielsen 2010-03-08 08:39:22 UTC
This has happened to me consistently on Windows Vista and 7. It occurs any time I don't manually remove the Squeezebox Server icon from the system tray before upgrading.
Comment 3 Paul Chandler 2010-03-25 09:51:17 UTC
Yes, it does seem to be a timing issue---if I 're-try' after a few seconds, it can replace the file (SBtray.exe)
Comment 4 Kris Murphy 2010-03-26 11:29:26 UTC
If this is happening consistently on Vista and Win7 then I would consider this a defect.  Yes, the software appears to be doing what it is designed, but can we do to improve the user experience?  Can the wait time be increased so the user doesn't encounter this?
Comment 5 Chris Owens 2010-03-29 13:52:57 UTC
Michael, is it possible to increase that timeout, or just put in a wait(); at some point?  I know it's ugly, but if it is safe and would cut tech support calls, it might be worth it.

Thanks for any info!
Comment 6 Michael Herger 2010-03-29 14:02:18 UTC
I'm hesitating upping the timeout even more - we're already at 2 minutes. Enough for many users to consider it "crashed" and kill it imho.

How many calls are there? Is this a real issue? I've never seen it happen myself on various Windows installations (2000/XP/2003/Vista/7)
Comment 7 Paul Chandler 2010-03-31 17:18:57 UTC
Reproduced it on Win7 Ultimate (T60 laptop) and on Vista32 
(on a fast system with lots of RAM)
Comment 8 Michael Herger 2010-04-01 03:28:50 UTC
Ok, just tried this again: working fine on 32-bit W7, but I'm seeing this behaviour on a 64-bit W7. Both are plain vanilly, not even an antivirus installed (but both are virtual machines). 

On the 64-bit machine it wouldn't even wait a second for the tray icon to be closed. It's not a timeout issue. Or do you see a considerable delay before you get that message?
Comment 9 SVN Bot 2010-04-01 04:33:10 UTC
 == Auto-comment from SVN commit #30458 to the slim repo by mherger ==
 == https://svn.slimdevices.com/slim?view=revision&revision=30458 ==

Bug: 15841
Description: delay extraction of SqueezeTray.exe, as it's potentially not fully unloaded yet from the memory under certain circumstances.
Comment 10 SVN Bot 2010-04-01 05:06:18 UTC
 == Auto-comment from SVN commit #30462 to the slim repo by mherger ==
 == https://svn.slimdevices.com/slim?view=revision&revision=30462 ==

Bug: 15841
Description: backport change 30458 to be included with 7.5.0
Comment 11 Michael Herger 2010-04-01 06:45:06 UTC
Could you please give the latest 7.5.0 nightly build another try?

http://downloads.slimdevices.com/nightly/?ver=7.5
Comment 12 Paul Chandler 2010-04-01 09:23:37 UTC
With Build 7.5.0.30462, I was able to upgrade from 7.4.2 on Win7 (2 machines) and Vista 32 -----WITHOUT getting the 'file replacement' error
Comment 13 Michael Herger 2010-04-01 09:42:42 UTC
Paul - just to be sure: you consider this fixed?
Comment 14 Cory Nielsen 2010-04-01 10:01:36 UTC
I also verified the fix. I can reproduce the issue at will using yesterday's build of 7.5, but don't see the error when upgrading from 7.4.2 to today's 7.5 build.