Bugzilla – Bug 15824
Favourites context-menus broken
Last modified: 2010-09-13 12:01:51 UTC
Cannot add, play next, or remove favourite
Some debug from the squeezeplay side request for initial favorites menu: { --[[table: 0x1723ef40]] "favorites", "items", 0, 200, "menu:favorites", "useContextMenu:1", } Dump of a favorite menu item (from _actionHandler): { --[[table: 0x16e5b0d0]] playAction = "go", ["icon-id"] = "html/images/artists.png", style = "itemplay", text = "Daniel Lanois", actions = { --[[table: 0x17210ea0]] ["add-hold"] = { --[[table: 0x17209730]] cmd = { --[[table: 0x16eaea70]] "favorites", "playlist", "insert", }, itemsParams = "params", player = 0, params = { --[[table: 0x162e9030]] favorites_title = "Daniel Lanois", favorites_type = "audio", favorites_url = "db:contributor.namesearch=DANIEL%20LANOIS", isContextMenu = 1, item_id = "0", type = "audio", }, }, go = { --[[table: 0x16eacc60]] cmd = { --[[table: 0x16e4b9d0]] "favorites", "playlist", "play", }, player = 0, nextWindow = "nowPlaying", itemsParams = "params", params = { --[[table: 0x16e095b0]] favorites_title = "Daniel Lanois", favorites_type = "audio", favorites_url = "db:contributor.namesearch=DANIEL%20LANOIS", isContextMenu = 1, item_id = "0", type = "audio", }, }, more = { --[[table: 0x16299370]] cmd = { --[[table: 0x16e88460]] "favorites", "items", }, itemsParams = "params", params = { --[[table: 0x16e19000]] favorites_title = "Daniel Lanois", favorites_type = "audio", item_id = "0", favorites_url = "db:contributor.namesearch=DANIEL%20LANOIS", isContextMenu = 1, type = "audio", menu = "favorites", }, }, add = { --[[table: 0x162bac10]] cmd = { --[[table: 0x16e4a390]] "favorites", "playlist", "add", }, itemsParams = "params", player = 0, params = { --[[table: 0x16e03a70]] favorites_title = "Daniel Lanois", favorites_type = "audio", favorites_url = "db:contributor.namesearch=DANIEL%20LANOIS", isContextMenu = 1, item_id = "0", type = "audio", }, }, }, params = { --[[table: 0x1722ce20]] favorites_title = "Daniel Lanois", favorites_type = "audio", favorites_url = "db:contributor.namesearch=DANIEL%20LANOIS", isContextMenu = 1, item_id = "0", type = "audio", }, } Request for CM (add/more): { --[[table: 0x172a68b0]] "favorites", "items", 0, 200, "item_id:0", "favorites_title:Daniel Lanois", "favorites_type:audio", "xmlBrowseInterimCM:1", "favorites_url:db:contributor.namesearch=DANIEL%20LANOIS", "isContextMenu:1", "type:audio", "menu:favorites", "useContextMenu:1", }
I'm going to spend a bit more time with this yet, but I think this is going to be hard to solve. I also tested against 7.4, and it's quite broken there too.
Adding priority of P2
Created attachment 6596 [details] squeezeplay-side of the patch one liner to make sure to refresh the underlying menu after a delete favorite is issued from a CM most of this bug's fix comes from the server side, in the next patch.
Created attachment 6597 [details] send playlist control and favs items to CMs for favorites This will send the 4 items Play/Play Next/Add to End/ and Delete Favorite to the CM of Favorites, while not impinging on the already correct CMs for local music that are driven by the *info menus.
This bug is effectively solved, but the patches need to be applied yet. Process dictates this is not going to be checked in for 7.5.0.
Targeting for 7.5.1 at Ben's suggestion that all patch_waiting bugs be fixed
== Auto-comment from SVN commit #30559 to the slim repo by bklaas == == http://svn.slimdevices.com/slim?view=revision&revision=30559 == Bug: 15824 Description: apply server side portion of the patch from this bug send playlist control and favs items to CMs for favorites
== Auto-comment from SVN commit #8687 to the jive repo by bklaas == == http://svn.slimdevices.com/jive?view=revision&revision=8687 == Fixed Bug: 15824 Description: refresh the underlying window from the CM so the favs menu immediately shows changes made via the CM
Since these are fixed, they must not be patch_waiting after all