Bug 15809 - MP4 (AAC) file encoded with ffmpeg may not play because of use of unsupported encoding type
: MP4 (AAC) file encoded with ffmpeg may not play because of use of unsupported...
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Audio
: 7.4.x
: All All
: P2 normal (vote)
: 7.5.0
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-01 06:07 UTC by Alan Young
Modified: 2010-04-08 17:24 UTC (History)
1 user (show)

See Also:
Category: Bug


Attachments
Sample file (3.38 MB, application/octet-stream)
2010-03-01 06:09 UTC, Alan Young
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2010-03-01 06:07:53 UTC
It would seem that the tags within an MP4 ES_Descriptor ('esds' box) may have their length fields encoded using a self-delimiting variable number of bytes. Most encoders seem to use a fixed length of 4 bytes and this is all that SP handles.  We need to be able to decode the ES_Descriptor sufficiently to identify the Decode-Specific Info Tag and its contents. The variable-length nature of the contents introduced by the encoding options above mean that cannot be done on the bases of absolute offset (35).
Comment 1 Alan Young 2010-03-01 06:09:38 UTC
Created attachment 6583 [details]
Sample file
Comment 2 Alan Young 2010-03-01 06:13:26 UTC
A fix would require regression-testing against AAC (AAC-LC), AAC-HD and ALAC, all of which use the MP4 container.
Comment 3 Chris Owens 2010-03-01 09:18:27 UTC
This came up in the bug meeting, but we didn't know what to talk about.  Please feel free to follow up with the relevant parties or we can talk about it in next week's meeting.
Comment 4 Chris Owens 2010-03-01 15:56:21 UTC
You sent email about this bug.  This priority and target seem correct to me.  Thanks!
Comment 5 SVN Bot 2010-03-03 02:06:57 UTC
 == Auto-comment from SVN commit #6680 to the player repo by ayoung ==
 == https://svn.slimdevices.com/player?view=revision&revision=6680 ==

Fixed bug 15809: MP4 (AAC) file encoded with ffmpeg may not play because of use of unsupported encoding type 
Do a better job of parsing the 'esds' box and propagate errors back up.
Tested with a variety of AAC-LC, AAC-HD and ALAC tracks.
Comment 6 SVN Bot 2010-03-03 02:07:04 UTC
 == Auto-comment from SVN commit #8620 to the jive repo by ayoung ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8620 ==

Fixed bug 15809: MP4 (AAC) file encoded with ffmpeg may not play because of use of unsupported encoding type 
Do a better job of parsing the 'esds' box and propagate errors back up.
Tested with a variety of AAC-LC, AAC-HD and ALAC tracks.
Comment 7 Chris Owens 2010-04-08 17:24:29 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!