Bug 15740 - Applet Installer fails in windows squeezeplay
: Applet Installer fails in windows squeezeplay
Status: RESOLVED FIXED
Product: SB Desktop
Classification: Unclassified
Component: Menu
: unspecified
: PC Windows XP
: -- normal (vote)
: 7.5.x
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-19 14:00 UTC by KDF
Modified: 2010-03-05 10:51 UTC (History)
5 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2010-02-19 14:00:14 UTC
it seems that luamd5 isn't being built for the windows build, so applet installer will not work.  It dumps an error:

1266616759.413 ERROR  squeezeplay.applets - :474 Error while loading applet SetupAppletInstaller:.../SetupAppletInstaller/SetupAppletInstallerApp
let.lua:32: module 'sha1' not found:
        no field package.preload['sha1']
        no file 'C:\Documents and Settings\kdean\Application Data/SqueezePlay\userpath\sha1.lua'
        no file '.\sha1.lua'
        no file 'C:\Personal\squeezeplay\src\Debug\lua\sha1.lua'
        no file 'C:\Personal\squeezeplay\src\Debug\lua\sha1\init.lua'
        no file 'C:\Personal\squeezeplay\src\Debug\sha1.lua'
        no file 'C:\Personal\squeezeplay\src\Debug\sha1\init
1266616759.429 WARN   squeezeplay.ui.draw - jiveL_dispatch_event:769 error in event function:
        ...ts/SetupAppletInstaller/SetupAppletInstallerMeta.lua:42: attempt to index local 'applet' (a nil value)
stack traceback:
        ...ts/SetupAppletInstaller/SetupAppletInstallerMeta.lua:42: in function <...ts/SetupAppletInstaller/SetupAppletInstallerMeta.lua:42>
        (tail call): ?
        ...nal\squeezeplay\src\Debug\lua\jive\ui\SimpleMenu.lua:189: in function 'itemListener'
        ...\Personal\squeezeplay\src\Debug\lua\jive\ui\Menu.lua:150: in function <...\Personal\squeezeplay
Comment 1 SVN Bot 2010-02-22 11:43:01 UTC
 == Auto-comment from SVN commit #8541 to the  repo by adrian ==
 == https://svn.slimdevices.com/?view=revision&revision=8541 ==

Bug: 15740
Description: make version number 3 digits so it matches other platforms (and applet installer can parse in the same way)
Comment 2 SVN Bot 2010-02-22 13:56:22 UTC
 == Auto-comment from SVN commit #8542 to the  repo by adrian ==
 == https://svn.slimdevices.com/?view=revision&revision=8542 ==

Bug: 15740
Description: project files to build md5.dll and sha1.dll for windows
Comment 3 Adrian Smith 2010-02-22 14:00:05 UTC
I've added two VC projects which build the relavent dlls, but they are from VC++ Express and the Jive.sln file has many more changes than I expect from the Visual Studio version.  Could someone with Visual Studio add the projects to the solution and commit the change to Jive.sln, assuming the projects work ok?

[its intentional the two projects share source files]

Thanks...
Comment 4 KDF 2010-02-22 14:55:33 UTC
can't get either project to build, neither individually nor as part of the jive project.
Comment 5 Adrian Smith 2010-02-22 15:19:29 UTC
Forgot to say - they should work if you add them to the main solution and make the depend on lua

That should add lua.lib to the link phase - was this the problem?
Comment 6 KDF 2010-02-22 15:40:51 UTC
yup.  I added dependancy for both and it's fine now. the jive.sln diff looks reasonable (it adds the two projects with dependancies and the IDs to the output configurations).  The only thing that is Express-specific is the comment at the top.
Comment 7 Adrian Smith 2010-02-22 15:51:33 UTC
Do you want to commit the sln then?  I can't until tomorrow.
Comment 8 SVN Bot 2010-02-22 16:01:29 UTC
 == Auto-comment from SVN commit #8545 to the  repo by kdf ==
 == https://svn.slimdevices.com/?view=revision&revision=8545 ==

Bug: 15740
Description: add sha1 and md5 to top level project.  both require the dependancies on lua.
Comment 9 KDF 2010-02-24 09:49:31 UTC
seems to work in latest nightly, so I'll take that as a sign that the build is working with the project changes.
Comment 10 Adrian Smith 2010-02-24 10:18:03 UTC
Kevin - see the last post to the forum message from usch:

Cool, thanks. It does work now ... almost.

md5.dll and sha1.dll are referencing Microsoft.VC90.DebugCRT which does not exist here, causing a system error 14001. I patched the DLLs to reference Microsoft.VC90.CRT instead and it seems ok. So once you flip the switch from Debug to Release I think we're there. 


This suggest we are linking against the wrong runtime libraries.  Do you know what could be causing this?
Comment 11 KDF 2010-02-24 10:53:08 UTC
hmm...
well, thanks for adding the comment.  I seem to only randomly get forum posts any more as I have seen none of this in email.

I think it's a problem in the two project files.  fill commit something around lunchtime when I can test
Comment 12 SVN Bot 2010-02-24 11:50:25 UTC
 == Auto-comment from SVN commit #8568 to the  repo by kdf ==
 == https://svn.slimdevices.com/?view=revision&revision=8568 ==

Bug: 15740
Description: remove debug info from sha1 and md5 projects' release configuration properties.
Comment 13 Chris Owens 2010-03-04 17:58:34 UTC
Changing the target since I'm not worried about this issue for the 7.5.0 release.
Comment 14 Adrian Smith 2010-03-05 10:51:42 UTC
Its actually fixed now..