Bug 15723 - wrong Icons showing up for my Apps and Apps gallery and more
: wrong Icons showing up for my Apps and Apps gallery and more
Status: RESOLVED FIXED
Product: SB Touch
Classification: Unclassified
Component: UI
: 7.5.0
: PC Windows XP
: P2 normal with 2 votes (vote)
: 7.6.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-16 16:34 UTC by Ryan
Modified: 2012-11-22 19:17 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments
album artwork mixed up (113.59 KB, image/png)
2010-02-26 06:11 UTC, Michael Herger
Details
register plugin icons in noweb mode (613 bytes, patch)
2010-02-26 06:21 UTC, Michael Herger
Details | Diff
app icons using 24 Nights (Clapton) and 1999 (Prince) covers (96.24 KB, image/png)
2010-02-26 06:30 UTC, Michael Herger
Details
wrong App icons, blurry NP screen version (108.52 KB, image/png)
2010-03-17 06:23 UTC, Michael Herger
Details
log file saved shortly after Blank icon event (59.81 KB, text/plain)
2010-03-24 13:30 UTC, Ryan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan 2010-02-16 16:34:50 UTC
while playing from an SD card I sometimes get the wrong icons for menu items.
My Apps and App Gallery. For App Gallery I have seen the staff picks icon and have also seen album art instead of the icon. For My Apps I get the internet radio local icon.
 For internet radio local I have had blank album art and internet radio music the local radio icon

internet radio talk has music, sports has talk, world has sports, 

At another time I will get them mixed up in a different way

Select a Pandora station or otherwise switch to MSB.com and the icons correct themselves.

fw 8504
Comment 1 Michael Herger 2010-02-17 07:51:18 UTC
Yep, seen this too: TinySBS will sometimes mess up built in icons. I've never seen this happen with the embedded branch on a PC/Linux.
Comment 2 Michael Herger 2010-02-26 05:31:42 UTC
Reading the report again I can say that I see the exact same two wrong icons for App Gallery and My Apps. Seems to be consistant across devices.
Comment 3 Michael Herger 2010-02-26 06:11:34 UTC
Created attachment 6569 [details]
album artwork mixed up

I think tinysbs is mixing up the queue: if several icons need to be rendered and get into a queue, the seem to get shifted around, being attributed to the next or previous item etc.
Comment 4 Michael Herger 2010-02-26 06:21:46 UTC
Created attachment 6570 [details]
register plugin icons in noweb mode

the app icons probably fail due to the fact that the plugins icons never get registered in noweb mode
Comment 5 Michael Herger 2010-02-26 06:30:51 UTC
Created attachment 6571 [details]
app icons using 24 Nights (Clapton) and 1999 (Prince) covers

one more experience re. my messed queue theory:

- SP connected to some server
- triggered wipe/rescan on Touch
- on SP went to My Music/Switch Source/Touch -> got connected to SB Touch while it was still scanning
- entered Albums: no cover art displayed
- went to Home: apps items show the two aforementioned covers

-> 1999 and 24 Nights very likely are the alphabetically first albums in my list
-> it looks as if the first to be shipped icon is being used for the first item actually on screen: albums view put 1999/24nights top in the queue, but when they eventually were ready to be displayed, the first two items to show a server provided icon were the two apps menu items
Comment 6 SVN Bot 2010-02-26 07:21:36 UTC
 == Auto-comment from SVN commit #30265 to the slim repo by mherger ==
 == https://svn.slimdevices.com/slim?view=revision&revision=30265 ==

Bug: 15723
Description: register plugin icons in noweb mode
Comment 7 Michael Herger 2010-02-26 07:22:45 UTC
Andy - with that patch applied, and not trying to display any artwork before the scan has finished all seems fine. Just don't request artwork before the artwork scan is done...
Comment 8 Michael Herger 2010-03-01 05:14:32 UTC
IMHO this is not a pure server side issue (if at all!), but rather SP. Maybe related to Alan's recent caching changes.

After I had seen the issue in the album list again, I cleanly unplugged drives, restarted fab4, and tried again. This time I scrolled down slowly. The artwork which was wrong before the start was now ok. But as soon as I scrolled fast enough that some items got off the screen before they actually were displayed, things got confused. The very first item I made scroll off the screen before it had its icon shown stayed empty, the next item got its artwork instead. And when scrolling back, the previously empty icon was replaced with some (guess not so) random other artwork.

Also: if I restart fab4 while it's connected to the embedded server, after the start it would show the same (wrong) icons as initially reported for the apps menu items again. As embedded SBS takes some time to start up it obviously times out waiting for those icons, replacing them with something else (same behaviour as when the plugin didn't publish those icons)
Comment 9 SVN Bot 2010-03-03 12:16:01 UTC
 == Auto-comment from SVN commit #30318 to the slim repo by agrundman ==
 == https://svn.slimdevices.com/slim?view=revision&revision=30318 ==

Fixed bug 15723, don't allow async artwork resize requests to get out of order
Comment 10 Ryan 2010-03-04 10:24:03 UTC
fw 8627  I am looking at now playing Santana Taboo with a Mediafly Icon as album art. Also the home menu App gallery icon has the Santana album art. This is with the SD card installed and TinySC running.
Comment 11 Mickey Gee 2010-03-09 16:36:00 UTC
*** Bug 15869 has been marked as a duplicate of this bug. ***
Comment 12 Chris Owens 2010-03-09 17:29:43 UTC
Okay you are *looking at it* but how did you get to that state?  Are you working with a local server or with mySB.com?  Are you playing local music or music from a service?  Thanks for additional info!
Comment 13 Andy Grundman 2010-03-12 07:43:12 UTC
I cannot reproduce this and I added an automated test that should show if this 
is still happening, and that works fine.

In order to get anywhere we need a log with artwork and network.http set to 
debug.  On TinySC you will have to modify the init script to enable this 
logging.

In /etc/init.d/squeezecenter, change:

nice -n 5 $BASE/slimserver.pl --charset utf8 --noweb --notranscoding 
--nosb1slimp3sync --nostatistics --noinfolog --nodebuglog --logfile syslog &

to

nice -n 5 $BASE/slimserver.pl --charset utf8 --noweb --notranscoding 
--nosb1slimp3sync --nostatistics --logfile syslog --debug artwork,network.http &

There will be a lot of log output, so as soon as you reproduce the problem, 
stop TinySC and get the log file.
Comment 14 Michael Herger 2010-03-17 06:23:29 UTC
Created attachment 6659 [details]
wrong App icons, blurry NP screen version

Just saw this again. I still think this is related to some stress load situation: started TinySBS on Touch, and while it was doing its initial scan I connected a receiver using the Controller to it. The NP version first didn't show up, only when I went to the NP playlist and back it showed, but very blurry. It looks as if the playlist icon had been used and scaled up.

The icon used on the App Gallery item is an album Random Play would have played in that moment (the one before David Bowie).

On the Touch itself everything is ok: App icons, and the NP version is crisp and clear.

fab4 firmware v7.5.0 r8652
Comment 15 Chris Owens 2010-03-22 09:27:52 UTC
We need to get a log file of this happening.  If we can't get a solid fix before the 7.5.0 release, I am okay with releasing with this bug, given that it's difficult to reproduce.
Comment 16 Chris Owens 2010-03-23 17:32:50 UTC
Ryan if you see this again could you show me so I can be sure of my judgment about its severity?  Thanks!
Comment 17 Michael Herger 2010-03-23 23:00:31 UTC
Chris - see the attached images.
Comment 18 Ryan 2010-03-24 09:40:36 UTC
Chris -  Ever since I added the code modification to log the event details when it happens, I have not been able to recreate this again. I have been trying so I could get a log to send.
Comment 19 Ryan 2010-03-24 13:30:15 UTC
Created attachment 6695 [details]
log file saved shortly after Blank icon event

I hope this can help
Comment 20 Andy Grundman 2010-03-24 13:32:20 UTC
Did you have artwork debugging on?  I don't see any artwork log entries in that log file.
Comment 21 Nicholas 2011-08-19 09:36:18 UTC
Blank Icons

Logitech Touch.  7.6.0 r9458

When running Squeezebox Server on a 32GB SD card the "app" icons in the main menu are sometimes  blank (appear black): CBC and PODCASTS. Clicking on them navigates to the correct page

These icons always display correctly when the Touch is connected to mysqueezebox.com
Comment 22 David Gardner 2011-08-23 12:47:43 UTC
(In reply to comment #21)
> Blank Icons
> 
> Logitech Touch.  7.6.0 r9458
> 
> When running Squeezebox Server on a 32GB SD card the "app" icons in the main
> menu are sometimes  blank (appear black): CBC and PODCASTS. Clicking on them
> navigates to the correct page
> 
> These icons always display correctly when the Touch is connected to
> mysqueezebox.com

Same issue with final 7.6.1.

Missing App Gallery, Napster, Sounds and Effects icons when connected to TinySC on all players (2 x Radio, Squeezeplay and Touch itself). Icons are there when connected to Windows Squeezeserver 7.6.1.
Comment 23 Dan 2011-08-23 19:18:37 UTC
I can confirm this is happening when using Tiny SC with 7.6.1.  All App Icons are missing accept for Radio IO.
Comment 24 Michael Herger 2011-08-24 08:19:18 UTC
I would have preferred to open a new bug for this issue... but so be it:

[11-08-24 17:15:50.4577] Slim::Web::Graphics::artworkRequest (83) Artwork request: plugins/SpotifyLogi/html/images/icon_41x41_m.png
[11-08-24 17:15:50.4971] Slim::Web::Graphics::artworkRequest (123)   Resize specification: 41x41_m.png
[11-08-24 17:15:50.5131] Slim::Web::Graphics::artworkRequest (269)   Looking for: plugins/SpotifyLogi/html/images/icon.png in skin Default
[11-08-24 17:15:50.5306] Slim::Web::Graphics::artworkRequest (351)   File not found, returning 404


Some change in S::W::G must have broken lookup of locally stored artwork.
Comment 25 SVN Bot 2011-08-24 13:02:31 UTC
 == Auto-comment from SVN commit #33172 to the slim repo by mherger ==
 == http://svn.slimdevices.com/slim?view=revision&revision=33172 ==

Fixed Bug: 15723
Description: we need to push the plugins' HTML folder on TT's INCLUDE_PATH even in noweb mode. Otherwise the plugin icons can't be found.
Comment 26 Nicholas 2012-11-22 19:17:04 UTC
When running Squeezebox Server on a 32GB SD card the CBC and PODCASTS "app" icons in the main menu are sometimes  blank (appear black). Clicking on them navigates to the correct page. Cycling power for a reboot restores icons.

These icons always display correctly when the Touch is connected to mysqueezebox.com

7.7.2