Bug 15715 - layout bug in icon-based popup icons on Radio
: layout bug in icon-based popup icons on Radio
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: UI Skin
: 7.4.x
: PC Other
: P2 normal (vote)
: 7.5.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-16 08:45 UTC by Ben Klaas
Modified: 2010-04-08 17:26 UTC (History)
2 users (show)

See Also:
Category: Bug


Attachments
screenshot of current buggy layout (30.50 KB, image/png)
2010-02-16 08:47 UTC, Ben Klaas
Details
fixed popup (36.12 KB, image/png)
2010-02-16 08:48 UTC, Ben Klaas
Details
patch to add 26 pixels of left and top padding to transport icons in popups (1.38 KB, patch)
2010-02-16 08:49 UTC, Ben Klaas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2010-02-16 08:45:06 UTC
QVGA skins: the icons in icon-based popups are not centered in the popup.

These popups are only seen when using an IR remote with the Radio (otherwise they are suppressed by design)

I believe the accessory pack that also includes the battery will have an IR remote with it? If so, this should really go in 7.4.2 not 7.5.0

I already have a fix, it's _extremely_ low risk. All it does is add 26 pixels of left and top padding on these icons.

Screenshots and patch coming
Comment 1 Ben Klaas 2010-02-16 08:47:56 UTC
Created attachment 6531 [details]
screenshot of current buggy layout

this is how a popup for hitting stop on the IR remote in Radio will look
Comment 2 Ben Klaas 2010-02-16 08:48:56 UTC
Created attachment 6532 [details]
fixed popup
Comment 3 Ben Klaas 2010-02-16 08:49:27 UTC
Created attachment 6533 [details]
patch to add 26 pixels of left and top padding to transport icons in popups
Comment 4 Chris Owens 2010-02-18 10:02:38 UTC
Oops I forgot to remove bug_meeting from these bugs.
Comment 5 SVN Bot 2010-02-18 12:15:20 UTC
 == Auto-comment from SVN commit #8523 to the  repo by bklaas ==
 == https://svn.slimdevices.com/?view=revision&revision=8523 ==

Fixed Bug: 15715
Description: fix layout of icon-based popup icons on QVGA skins (Radio and Controller)
Comment 6 Chris Owens 2010-04-08 17:26:42 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!