Bug 15714 - Jive process runs at 100% when playing live flac streams
: Jive process runs at 100% when playing live flac streams
Status: RESOLVED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Audio
: 7.5.x
: Other Linux (other)
: -- normal (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-16 03:46 UTC by Adrian Smith
Modified: 2010-02-17 07:05 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments
Proposed patch (1.58 KB, patch)
2010-02-16 03:49 UTC, Adrian Smith
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Smith 2010-02-16 03:46:08 UTC
When playing a flac steam generated by the server by transcoding a live stream, jive can run at 100% as there is minimum number of bytes the flac decoder requires before processing.
Comment 1 Adrian Smith 2010-02-16 03:49:37 UTC
Created attachment 6530 [details]
Proposed patch

This fixes it - any views Felix?
Comment 2 Felix Mueller 2010-02-16 04:01:24 UTC
Hi Adrian

Thanks for the patch. It looks straight forward to me, but I am the wrong person to ask. You better ask Alan or Andy about audio streaming stuff.

Also I do not know what ultimately will happen to the Beta Playback feature on Controller in general.
Comment 3 Adrian Smith 2010-02-16 04:07:08 UTC
This impacts fab4 and radio + desktop.  I consider it the right thing to do to avoid this.

Are Andy or Alan around this week?  Otherwise I propose to commit it as its low risk.
Comment 4 Felix Mueller 2010-02-16 07:07:38 UTC
Alan is on vacation this week, but Andy should be around although I think he is in Fremont right now, so different timezone.
Comment 5 Andy Grundman 2010-02-16 08:01:52 UTC
Good catch, patch looks fine to me.
Comment 6 SVN Bot 2010-02-16 08:19:29 UTC
 == Auto-comment from SVN commit #8511 to the  repo by adrian ==
 == https://svn.slimdevices.com/?view=revision&revision=8511 ==

Bug: 15714
Description: flac decoder requires minium number of bytes before it will decode anything, don't try to stream immediately if we don't have this many bytes in streambuf
Comment 7 Alan Young 2010-02-17 07:05:05 UTC
This was a regression. This specific issues was fixed once before, both (separately) in ip3k f/w and SP