Bugzilla – Bug 15699
Analog clock crashes due to jive surface and tile C changes in r8498
Last modified: 2010-04-08 17:24:06 UTC
See forum thread linked here. Rotozoom called in wrong context crashes squeezeplay
Created attachment 6521 [details] crashlog when using ImageViewer I've seen the same crash using Flickr as the screensaver etc.
== Auto-comment from SVN commit #8499 to the repo by adrian == == https://svn.slimdevices.com/?view=revision&revision=8499 == Bug: 15699 Description: avoid crashes due to r8498 when JiveTile and JiveSurface are mixed up - whenever we detect the wrong type of object terminate processing on it as well as generate an error, this protects against crashing - fix rotozoom, zoom and shrink to process tile or surface Note there are other cases where a tile rather than a surface could be created and then the surface drawing methods used on it - this is not fixed. To be reviewed by Alan to see what it should really do....
Adrian solved the crash situation with Surface:rotozoom(). Assigning to Alan so he gets some visibility on this. Alan, if you think this is a complete solution, go ahead and close. At the user-facing level there is no apparent issue now.
Adrian, were those 6 methods the only ones implicated in the problem? My reading of the change is that it simply avoids the crash rather than fixes the underlying problem. Do the analogue clock and flickr screensaver work with that change? In any case, it is easy enough to fix those specific cases so that they will work properly. I'll look at that next week.
Yes, the analog clock and flickr both work after Adrian's change.
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release. If you are still seeing this issue, please let us know!