Bug 15694 - USB & SDcard libraries are displayed in a confusing manner
: USB & SDcard libraries are displayed in a confusing manner
Status: CLOSED FIXED
Product: SB Touch
Classification: Unclassified
Component: TinySC
: 7.5.0
: Other Other
: P2 normal (vote)
: 7.5.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-12 16:50 UTC by Dan Evans
Modified: 2010-04-08 17:25 UTC (History)
5 users (show)

See Also:
Category: ---


Attachments
make TinySBS advertise the media used in the libraryname (1.75 KB, patch)
2010-02-17 07:26 UTC, Michael Herger
Details | Diff
SP side approach (4.50 KB, patch)
2010-02-17 22:49 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Evans 2010-02-12 16:50:13 UTC
When you plug in a USB thumb drive with music tinySC activates and scans the available music.  Fine, no problem.

But going to Home > My Music you see the USB device listed "Squeezebox Touch" which is highly confusing.  It should be:

 "USB Device" or "USB Source"

Furthermore, if you plug in a SD card it is also labeled "Squeezebox Touch" which is equally confusing.  It should be:

 "SD Card" or "SD Card Source"

But...

The big whammy is if you have both a USB and a SD card plugged in.  Both are detected and both are featured on the main menu as "Eject XX" but only _one_ of them is listed in My Music.  (in my tests today it's the USB that appears and not the SD card.)  This is likely already known.  All we need is a method to switch or a way to see both.  Just wanted to be sure it's being tracked.

The naming cases above definitely need a change.
Comment 1 SVN Bot 2010-02-17 06:24:30 UTC
 == Auto-comment from SVN commit #8517 to the  repo by mherger ==
 == https://svn.slimdevices.com/?view=revision&revision=8517 ==

Bug: 15694
Description: update My Music heading whenever entering the music menu. This is needed to be up to date when switching local music sources from eg. USB to SD Card.
Comment 2 Michael Herger 2010-02-17 07:26:55 UTC
Created attachment 6539 [details]
make TinySBS advertise the media used in the libraryname
Comment 3 Michael Herger 2010-02-17 07:31:22 UTC
We have two possibilities: we can do it on the server side or on the squeezeplay side. Both have pros and cons:

Server:
- easier to implement
- will change libraryname for all players
- SP would still display "Connecting to SB Touch (SD)..." after ejecting SD and plugging in USB, as it doesn't know yet that the source has changed

Squeezeplay:
- needs more changes
- needs some server:isEmbedded() which we tried to prevent
- libraryname wouldn't need to change, the media name could be added when displayed

A quick discussion on campfire can be summarized by this quote: "This is all feeling like a big mess - maybe we should push back on Dan on the grounds that fixing this properly is likely to be a big, risky change?"

We should punt this post 7.5.0.
Comment 4 Dan Evans 2010-02-17 10:12:13 UTC
I can't quite understand what's the difficult part from Michael's response.  The issues listed in comment #0 are:

1. The library labels on USB/SD is confusing
2. When both a USB & SD are connected you cannot access both (or switch)

Are both of these issues equally difficult?  Is one the "big mess" and the other is easy?
Comment 5 Michael Herger 2010-02-17 13:07:15 UTC
1. does look easier than it is. The items you're seeing aren't static  
data, but are data sent by the servers. We can have the server tell what  
media it's using. But this in turn can lead to confusing labels if you  
unplug one media, then plug in the other. If at that point you try to  
browse your music, the spinny would say "connecting to A", while it's  
trying to connect to B. Only when the server is up and running and SP can  
actually connect to  it, the label would be updated (that's what my patch  
does).

The other solution is to hard code something in SP to add the media to  
those labels whenever an embedded server's item is to be displayed. Would  
be visually nicer, but hacky.

Thus Alan's "big mess" judgment.

2. at some point it was decided that for release only one media type at  
any given time will be supported by the embedded server. It was clear then  
that this will be a popular enhancement. But not in 7.5.0. Not for the  
initial release.
Comment 6 Michael Herger 2010-02-17 22:49:29 UTC
Created attachment 6541 [details]
SP side approach

For the archives: the SP based approach I was playing with yesterday. Would still need a server:isEmbedded() method.
Comment 7 Chris Owens 2010-02-18 09:53:20 UTC
Bear in mind, Dan, that this library name will be displayed on SB3s and Booms and other players that may be trying to connect to the TinySC.

It seems like part of the problem is that it's hard to always have the correct media type in the name.  Dan is it important to have SD or USB?  Or would a more generic term like 'Flash media' or something be okay?

Michael will go ahead and try his patch and we can have a look.  The new bug people are likely to complain about with this patch is 'I switched from SD to USB and it still says SD'
Comment 8 Chris Owens 2010-02-18 10:02:42 UTC
Oops I forgot to remove bug_meeting from these bugs.
Comment 9 SVN Bot 2010-02-19 02:40:23 UTC
 == Auto-comment from SVN commit #30211 to the  repo by mherger ==
 == https://svn.slimdevices.com/?view=revision&revision=30211 ==

Fixed Bug: 15694
Description: add media type to libraryname when running embedded SBS
Comment 10 Dan Evans 2010-02-19 10:33:31 UTC
I'm fine with a more generic name like "Flash media".  As long as our code iterates each discovered media such as "Flash media 1" and "Flash media 2" etc. to avoid the confusion we have now.

And I agree that users are going to be most confused when they are either trying to access a USB and a SD at the same, or if they remove one USB drive and plug in another.  Both of these situations need to be handled smoothly and with correct feedback provided to the user.
Comment 11 Andy Grundman 2010-02-19 10:41:22 UTC
"Flash media" is no good when most people will probably connect hard drives.
Comment 12 Dan Evans 2010-02-19 10:42:40 UTC
Is there a detectable difference between a USB hard drive and a USB thumb drive?
Comment 13 Ben Klaas 2010-02-19 10:43:25 UTC
There is not. I'm having a huge sense of deja vu here...I think this very topic was covered in a different bug...
Comment 14 Chris Owens 2010-04-08 17:25:51 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!