Bug 15658 – Have "Charging" item in Touch's sound effects

Bug 15658 - Have "Charging" item in Touch's sound effects

Summary:

Have "Charging" item in Touch's sound effects

Status:	CLOSED FIXED

Product:	SB Touch
Classification:	Unclassified
Component:	Settings
Version:	7.5.0
Platform:	Macintosh Debian Linux

Importance:	P3 normal (vote)
Target Milestone:	7.5.x
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-02-08 08:07 UTC by Michael Herger
Modified:	2010-09-13 12:00 UTC (History)
CC List:	3 users (show)

See Also:
Category:	Bug

Attachments
patch to add System capability check for battery capability and not show charging as a sound effect when not applicable (3.65 KB, patch) 2010-06-03 14:57 UTC, Ben Klaas	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2010-02-08 08:07:44 UTC

...should probably be hidden on any device without a battery installed.

Comment 1 Ben Klaas 2010-02-19 08:39:41 UTC

*** Bug 15622 has been marked as a duplicate of this bug. ***

Comment 2 Chris Owens 2010-03-08 11:30:27 UTC

Moving lower-priority bugs to next target

Comment 3 Ben Klaas 2010-06-03 14:57:28 UTC

Created attachment 6878 [details]
patch to add System capability check for battery capability and not show charging as a sound effect when not applicable

Comment 4 Ben Klaas 2010-06-03 14:58:53 UTC

Alan, cc:ing you in case you want to comment on the patch

note: this is adding a function for checking for battery capability, not for whether a battery is currently present.

Comment 5 SVN Bot 2010-06-15 09:02:16 UTC

 == Auto-comment from SVN commit #8854 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8854 ==

Fixed Bug: 15658
Description: add System:hasBatteryCapability() method for returning whether a device is capable of having a battery
Baby and Jive are battery capable, Desktop and Fab4 are not
Add code to SetupSoundEffects to not present option for Battery Charging in sound effects menu when not applicable

Comment 6 Chris Owens 2010-09-13 12:00:04 UTC

This bug has now been fixed in a released version of the Squeezeplay firmware (SB Touch, SB Radio, and SB Controller).  If you are still seeing this bug, please make certain you are running firmware 9009 or higher, and re-open it.

Thanks!