Bug 15630 - Invalid characters in comment tags can break the scanner
: Invalid characters in comment tags can break the scanner
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.4.1
: PC Windows XP
: P2 normal (vote)
: 7.5.0
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-05 14:19 UTC by emilien.schaffner
Modified: 2014-06-05 09:14 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
The scanner log (364.06 KB, text/plain)
2010-02-05 14:19 UTC, emilien.schaffner
Details
A file wich causing problem (6.74 MB, audio/mp3)
2010-02-08 08:44 UTC, emilien.schaffner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description emilien.schaffner 2010-02-05 14:19:36 UTC
Created attachment 6492 [details]
The scanner log

I'm sorry my English is not good but here is the problem :

When I add my music folder on the server after 2min it stops scanning... I
check the log and there is an error about caracter encoding... I check the
folder who's concerned by the error and didn't found any problem !

I've tried without the folder that create the problem and the same error occurs
further...

Here's some specials caracters that I've found : ö Ö ' ` &

I hope you can repair the bug with my informations

I have the same error with the version 7.4.2

My computer is in french (switzerland)

You can find my scan log in attachment.

PS : I found on the web that can be a problem with perl, maybe this url can
help you :
http://perl.markmail.org/search/?q=Warning%3A+Malformed+UTF-8+character#query:Warning%3A%20Malformed%20UTF-8%20character+page:1+mid:f2mkewydaxiwzz47+state:results

Thank very much for you work !!! Your system is very good !
Comment 1 Chris Owens 2010-02-05 17:17:21 UTC
The error in the log is: [10-02-05 21:47:19.1848] Slim::Schema::_preCheckAttributes (2098) Warning: Malformed UTF-8 character (character 0xffff) in pattern match (m//) at /<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Schema.pm line 2098.
Comment 2 Michael Herger 2010-02-07 23:50:05 UTC
I think you're mislead by the ö in Björk, as other entries scanned no problem (eg. [10-02-05 21:46:25.2300] Slim::Utils::Scanner::scanDirectory (333) Scanning: E:\My Files\MP3\A\Axelle Red\A Tâtons\01 A Tâtons.mp3
[10-02-05 21:46:25.3128] Slim::Utils::Scanner::scanDirectory (333) Scanning: E:\My Files\MP3\A\Axelle Red\A Tâtons\02 C'était.mp3
[10-02-05 21:46:25.3656] Slim::Utils::Scanner::scanDirectory (333) Scanning: E:\My Files\MP3\A\Axelle Red\A Tâtons\03 Mon Café (The Coffee Song).mp3).

I'd rather guess it's a problem with some file's tags. You mention it happens in one particular folder. Could you please upload a file from that folder (or the one last logged in the scanner.log)?
Comment 3 emilien.schaffner 2010-02-08 08:39:45 UTC
(In reply to comment #2)

I think you're right ! I tried to reorganize folders wich causing problems with mediamonkey (Utility for managing music) and  after that I passed the scann over all folders ! 
I've keep a copy of another folder wich causing the same problem, here is the log :

[10-02-08 17:29:15.9062] Slim::Music::Import::runImporter (567) Starting Slim::Music::MusicFolderScan scan
[10-02-08 17:29:20.6250] Slim::Utils::Scanner::scanDirectory (320) Found 202 files in E:\My Files\MP3 a problème avec squeezebox
[10-02-08 17:29:20.6271] Slim::Utils::Scanner::scanDirectory (333) Scanning: E:\My Files\MP3 a problème avec squeezebox\Bob Dylan\Bob Dylan & Janis Joplin  It ain't me babe (live 1964).MP3
[10-02-08 17:29:20.8308] Slim::Schema::_preCheckAttributes (2087) Warning: Malformed UTF-8 character (character 0xffff) in pattern match (m//) at /<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Schema.pm line 2087.
[10-02-08 17:29:20.8314] main::main (300) Error: Failed when running main scan: [Malformed UTF-8 character (fatal) at /<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Schema.pm line 2087.
]
[10-02-08 17:29:20.8318] main::main (301) Error: Skipping post-process & Not updating lastRescanTime!

you can find the file in attachment.

Thank you very much, finally it's maybe not a bug... sorry
Comment 4 emilien.schaffner 2010-02-08 08:44:25 UTC
Created attachment 6501 [details]
A file wich causing problem
Comment 5 Michael Herger 2010-02-08 09:57:44 UTC
Andy - is this another audio::scan issue or invalid data?

Bob Dylan & Janis Joplin It ain't me babe (live 1964).MP3	[ 4.00 MB ]
-------------------------------------------------------------------------------
Time: 02:56	MPEG1, Layer III	[ 192 kb/s @ 44100 Hz - Joint stereo ]
-------------------------------------------------------------------------------
ID3 v2.3:
title: BOB DYLAN & JANIS JOPLIN  IT AIN'T ME BABE (LIVE 1964)		artist: Bob Dylan
album: 		year: None
track: 		
'ascii' codec can't decode byte 0xc3 in position 28: ordinal not in range(128)
Comment 6 SVN Bot 2010-02-08 10:46:07 UTC
 == Auto-comment from SVN commit #30085 to the  repo by agrundman ==
 == https://svn.slimdevices.com/?view=revision&revision=30085 ==

Fixed bug 15630, skip comment strings with invalid utf-8
Comment 7 Chris Owens 2010-04-08 17:24:19 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!
Comment 8 Michael Herger 2014-06-04 14:46:26 UTC
I know, this is an oldie... but I just reverted the change supposed to fix this issue in 7.9. I wasn't able to make the scanner crash with the file provided here. I guess that the scanner re-write in 7.6 is dealing with this just fine.

Please let me know if you happen to see new issues due to this change.
Comment 9 Michael Herger 2014-06-04 14:46:47 UTC
Oh, I did so because this fix caused new issues (bug 17863).
Comment 10 Mike Walsh 2014-06-05 09:14:55 UTC
its also possible that the bug was specific to XP, did u test against that?

considering XP is now EOL, I don't think it should matter if the bug only exists on XP and other EOL windows OS's.  of course, the bug might or might not exist in newer OS's too.