I'll take this

during scan, the player:getModel() is returning "controller"

20100210 16:54:25.336 WARN   applet.SelectPlayer - SelectPlayerApplet.lua:214 Player: Player {Squeezebox Touch} is model: controller

after scan (and player connected notification goes out), player:getModel() returns "fab4"

20100210 16:54:25.541 WARN   applet.AlarmSnooze - AlarmSnoozeApplet.lua:265 notify_playerConnected: Player {Squeezebox Touch} nil

20100210 16:54:31.589 WARN   applet.SelectPlayer - SelectPlayerApplet.lua:214 Player: Player {Squeezebox Touch} is model: fab4

This was hard to reproduce, but now I can do it reliably by shutting off tinySC and then going into Choose Player

I added some debug to show when this is getting erroneously set to the wrong device type, and it's in the updateUDAP() Player method

Here's the traceback-

20100210 20:35:53.914 ERROR  squeezebox.player - Player.lua:500 updateUdap: setting player model: controller
stack traceback:
        ...ueezeplay/src/squeezeplay/share/jive/slim/Player.lua:500: in function 'updateUdap'
        .../share/applets/SlimDiscovery/SlimDiscoveryApplet.lua:160: in function '_udapSink'
        .../share/applets/SlimDiscovery/SlimDiscoveryApplet.lua:244: in function 'sink'
        .../squeezeplay/src/squeezeplay/share/jive/net/Udap.lua:128: in function 'snk'
        .../trunk/squeezeplay/build/osx/share/lua/5.1/ltn12.lua:275: in function 'step'
        ...ezeplay/src/squ
20100210 20:35:53.914 WARN   applet.SelectPlayer - SelectPlayerApplet.lua:214 Player: Player {Squeezebox Touch} is model: controller

cc:ing Felix. Felix, any idea why the udap packet would have the wrong device ID for the Fab4?

I took it a step further and dumped the UDAP packet after shutting down tinySC

device_id in the packet is 9, which is what Player.lua has for "controller". Is the id incorrect or the Player.lua mapping wrong?

{ --[[table: 0x16e17c10]]
  seqno = 1,
  source = "00042022001d",
  ucp = { --[[table: 0x16e17c30]]
    device_status = "wait_slimserver",
    type = "fab4",
    name = "Squeezebox Touch",
    firmware_rev = "7.5.0 r8470",
    device_id = "9",
    hardware_rev = "3",
  },
  udapType = 49153,
  uapClass = "00010001",
  udapFlag = 0,
  uapMethodId = 9,
  dest = "0004202600e7",
  uapMethod = "adv_discover",
  destType = 2,
  sourceType = 1,
}
20100210 20:44:25.611 ERROR  squeezebox.player - Player.lua:500 updateUdap: setting player model: controller
stack traceback:
        ...ueezeplay/src/squeezeplay/share/jive/slim/Player.lua:500: in function 'updateUdap'
        .../share/applets/SlimDiscovery/SlimDiscoveryApplet.lua:161: in function '_udapSink'
        .../share/applets/SlimDiscovery/SlimDiscoveryApplet.lua:245: in function 'sink'
        .../squeezeplay/src/squeezeplay/share/jive/net/Udap.lua:128: in function 'snk'
        .../trunk/squeezeplay/build/osx/share/lua/5.1/ltn12.lua:275: in function 'st

assign to Felix for feedback on UDAP device_ids

What device ID would you expect? Looking into the list in Player.lua I guess 12 (= squeezeplay)?

Udap is getting the device ID via getDeviceType() and device ID gets set via setDeviceType(). It is always set to 9 for every device.

See this change by Richard here:

http://svn.slimdevices.com/jive/7.5/trunk/squeezeplay/src/squeezeplay/share/jive/slim/LocalPlayer.lua?r1=4058&r2=4061

 == Auto-comment from SVN commit #8489 to the  repo by bklaas ==
 == https://svn.slimdevices.com/?view=revision&revision=8489 ==

Fixed Bug: 15612
Description: default to using udap.ucp.type for setting self.info.model

Just checked this with 8504