Bug 15549 – Embedded: changing tag separator does trigger new scan, but doesn't use the new prefs value

Bug 15549 - Embedded: changing tag separator does trigger new scan, but doesn't use the new prefs value

Summary:

Embedded: changing tag separator does trigger new scan, but doesn't use the n...

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Scanner
Version:	7.5.0
Platform:	Macintosh Debian Linux

Importance:	P3 normal (vote)
Target Milestone:	7.5.0
Assigned To:	Alan Young

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-01-27 23:05 UTC by Michael Herger
Modified:	2010-04-08 17:25 UTC (History)
CC List:	2 users (show)

See Also:
Category:	Bug

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2010-01-27 23:05:55 UTC

Using the 7.5/embedded branch (r29937). When I change the tag delimiter (splitlist) pref, a new full wipe & rescan is triggered, but it seems to still be using the old splitlist value.

Comment 1 Michael Herger 2010-01-27 23:09:09 UTC

Looking at the code I guess you'd even have to restart the server to make the new setting active:

From Slim::Music::Info::splitTag:

# Cache this preference, which may be undef
my ($_splitList, $_gotSplitList);

...


	
	if (!$_gotSplitList) {
		$_splitList = $prefs->get('splitList');
		$_gotSplitList = 1;
	}

	
Is this so performance critical?

Comment 2 Michael Herger 2010-01-27 23:17:52 UTC

http://svn.slimdevices.com/slim/7.5/branches/embedded/server/Slim/Music/Info.pm?r1=29180&r2=29183

 Alan - how much performance are we losing removing this caching? Or can we make sure the value is read when a new scan is triggered?

Comment 3 Alan Young 2010-01-28 22:58:04 UTC

Michael already fixed this.

Comment 4 Chris Owens 2010-04-08 17:25:27 UTC

This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!