Bug 15525 - Playtime count turns black after one hour
: Playtime count turns black after one hour
Status: RESOLVED FIXED
Product: SB Touch
Classification: Unclassified
Component: Now Playing
: 7.5.0
: All All
: P2 normal (vote)
: Investigating
Assigned To: Squeezebox QA Team email alias
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-24 05:37 UTC by Neil Davidson (Funkstar)
Modified: 2010-08-31 09:37 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Neil Davidson (Funkstar) 2010-01-24 05:37:13 UTC
When the playtime for a radio stream goes from mm:ss to h:mm:ss the text changes from white to black. I think it also drops the bold highlighting too.

Happens when playing 6Music through the BBC app or the iPlayer plugin.
Comment 1 Ben Klaas 2010-02-01 10:44:17 UTC
QA doesn't need to take this bug, I should be able to assess and fix it quickly. It's a skinning issue for sure.
Comment 2 Ben Klaas 2010-02-01 11:26:44 UTC
I was mistaken, I can't reproduce this. I put in some custom hacks to automatically do widget restyling and reformatting after 5 seconds and do not see this behavior.

Also, code review of the skin shows nothing out of place...

Neil, this is SB Touch only? Was it the "small text" skin in use? Had the unit done any skin switching between large and small text before the problem was seen?
Comment 3 Ben Klaas 2010-02-01 11:34:34 UTC
just in case this finds its way back to me, this is the hack to change the style and string format after 5 seconds instead of 1 hour...

=== NowPlayingApplet.lua
==================================================================
--- NowPlayingApplet.lua        (revision 38405)
+++ NowPlayingApplet.lua        (local)
@@ -88,7 +88,7 @@
        local min = math.floor((seconds / 60) - (hrs*60))
        local sec = math.floor( seconds - (hrs*3600) - (min*60) )
 
-       if hrs > 0 then
+       if hrs > 0 or sec > 5 then
                return string.format("%d:%02d:%02d", hrs, min, sec)
        else
                return string.format("%d:%02d", min, sec)
@@ -660,7 +660,8 @@
                local elapsedWidget = self.progressGroup:getWidget('elapsed')
                local elapsedLen    = string.len(strElapsed)
                local elapsedStyle  = elapsedWidget:getStyle()
-               if elapsedLen > 5 and elapsedStyle ~= 'elapsedSmall' then
+               --if elapsedLen > 5 and elapsedStyle ~= 'elapsedSmall' then
+               if elapsed > 6 and elapsedStyle ~= 'elapsedSmall' then
                        elapsedWidget:setStyle('elapsedSmall')
                elseif elapsedLen <= 5 and elapsedStyle ~= 'elapsed' then
                        elapsedWidget:setStyle('elapsed')
Comment 4 Neil Davidson (Funkstar) 2010-02-20 03:44:52 UTC
This is still happening for me.

Running r8524, with the standard Touch skin, playing the BBC iPlayer 6Music stream.

If I navigate away from Now Playing, to settings -> advances -> about for example, and let the Now Playing screen saver kick in, the elapsed time is still black and normal weighting (i.e. not bold).

Cycling through the now playing screens has no effect on the text, it remains black.
Comment 5 Ben Klaas 2010-08-31 09:37:36 UTC
Fixed in 7.6 r9082