Bugzilla – Bug 15524
Remote stream ShowBriefly are not shown any more
Last modified: 2011-03-16 04:47:14 UTC
Error messages for remote streams are sent to SqueezePlay but are not shown at present. This appears to be due to them being of type "song" which are not shown in all cases. Should there be an alternative type for warning messages as they should be shown. Can be fixed by changing type on SBS, but needs consitent view between SP and SBS.
if type = 'song' this is what happens in Player.lua: self.jnt:notify('playerTitleStatus', self, textValue, duration) then NowPlayingApplet should pick up the playerTitleStatus notification and briefly display the message in either the title bar (baby, controller) or the main area of NP (touch). FWIW, this change was intentional and came about from the direction of our UI designer. Specification was to pull way back on intrusive popups. if you send with type of 'popupplay', showBriefly will still appear. I see your point with this Triode but I'm not sure what the best solution is, given the previous guidance from UI design.
CC'ing Alan My main point is that there are error messages which the server produces which are not shown on squeezeplay players, but which are shown on non Squeezeplay players. They are sent from the server to the player and not shown. If this is by design then it may be best not to send them! However the main point is that Alan's code is generating error messages which noone will see on a new player..
Okay, then my recommendation is to use 'popupplay' for these. I think Alan asked me that this morning, so he's probably heading down that path already...
No, I was looking at a different issue.
Perhaps the problem is using the common method _playersMessage() for both connection/buffering-type progress messages, and for error messages. I guess that using popupplay for errors would be more appropriate.
I think that's correct Alan. Errors I think are appropriate to generate popups, rebuffering information and the like should show up via the playerTitleStatus notification method.
Created attachment 6488 [details] Proposed patch
patch looks good to me
== Auto-comment from SVN commit #30078 to the repo by ayoung == == https://svn.slimdevices.com/?view=revision&revision=30078 == bug 15524: Remote stream ShowBriefly are not shown any more Use popupplay type for errors
Fixed
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release. If you are still seeing this issue, please let us know!