Bug 15520 - MusicIP mix for a genre seed not correct
: MusicIP mix for a genre seed not correct
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: MusicIP
: 7.5.0
: PC Windows XP
: P2 normal (vote)
: 7.5.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-23 03:34 UTC by Philip Meyer
Modified: 2010-04-08 17:25 UTC (History)
0 users

See Also:
Category: ---


Attachments
Simple patch that fixes the problem (450 bytes, application/octet-stream)
2010-01-23 03:34 UTC, Philip Meyer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Meyer 2010-01-23 03:34:18 UTC
Created attachment 6455 [details]
Simple patch that fixes the problem

If I generate a MusicIP mix starting from a genre, it doesn't pass the correct
query string parameter to MusicIP server.

eg, Browse Genres, select MusicIP mix on "Classical", and it produces the
query:

http://localhost:10002/api/mix?filter=Classical&variety=2&filter=Not%20low%20rating&rejectsize=15&mixgenre=1&style=160&sizetype=tracks&size=50

i.e. it sets the query param filter=Classical, whereas it should be
genre=Classical.

This results in a random seed being used for the mix.

I found the problem in the MusicIP plugin, and have supplied a patch.

I am running 7.5.0/trunk SVN 29883.  Haven't checked if it is a problem in
earlier releases.
Comment 1 Chris Owens 2010-02-01 08:12:40 UTC
Michael, could you review Philip's patch for 7.5.0?
Comment 2 SVN Bot 2010-02-04 00:21:11 UTC
 == Auto-comment from SVN commit #30000 to the slim repo by michael ==
 == https://svn.slimdevices.com/slim?view=revision&revision=30000 ==

Fixed Bug: 15520
Description: enable genre mixing. Thanks Phil!
Comment 3 Chris Owens 2010-04-08 17:25:22 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!