Bug 15504 - One track playlists in NP, IR right and + button broken
: One track playlists in NP, IR right and + button broken
Status: CLOSED FIXED
Product: SB Touch
Classification: Unclassified
Component: Applet
: 7.5.0
: PC Other
: -- normal (vote)
: 7.5.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-19 17:29 UTC by Chris Owens
Modified: 2010-04-08 17:26 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Owens 2010-01-19 17:29:22 UTC
That's how the SB3 behaves.  Is there a good reason not to do that?
Comment 1 Chris Owens 2010-01-19 17:39:03 UTC
Ben I don't know if this is yours since it appears to be Touch-specific, or Andy's since it's Pandora.

Since his time is harder to come by than yours these days, I thought I'd ask you first.  :)
Comment 2 Andy Grundman 2010-01-20 06:12:33 UTC
I'm confused by this bug, the right arrow key never advances to the next track.  Right arrow takes you to trackinfo.
Comment 3 Ben Klaas 2010-01-20 08:15:54 UTC
I believe the correct behavior of right arrow with the IR remote (I have to assume that's what you're talking about?) is to launch the CM. Unfortunately, it does not do that either. I'm seeing IR right arrow from the NP screen on Touch do nothing...

so, if that's a bug to fix, it's probably mine.
Comment 4 Ben Klaas 2010-01-20 10:11:11 UTC
additional data, the + button on the NP screen is also non-functional.

it's also not limited to Pandora, this is broken for all playlists of only one track.

This used to work, so there was a regression somewhere along the way...
Comment 5 Ben Klaas 2010-01-20 11:17:09 UTC
on investigation, this is getting ugly.

First, the problem is not always reproducible. Initial tests show it's always reproducible with Pandora but not with single track local playlists. Slacker seems to work as well.

I added a stack traceback in the event handler and it's showing the widget source as Slider.lua, which is wrong. It appears the wrong widget is consuming the event.

Debug when Failing:

Jan 20 13:01:08 squeezeplay: ERROR  squeezeplay.ui - Widget.lua:446 Calling widget action listener for action: (go) from source: [/usr/share/jive/jive/ui/Slider.lua]:108
Jan 20 13:01:08 squeezeplay: stack traceback:
Jan 20 13:01:08 squeezeplay:    /usr/share/jive/jive/ui/Widget.lua:446: in function 'callback'
Jan 20 13:01:08 squeezeplay:    /usr/share/jive/jive/ui/Widget.lua:656: in function '_event'
Jan 20 13:01:08 squeezeplay:    /usr/share/jive/jive/ui/Group.lua:86: in function 'callback'
Jan 20 13:01:08 squeezeplay:    /usr/share/jive/jive/ui/Widget.lua:656: in function </usr/share/jive/jive/ui/Widget.lua:632>
Jan 20 13:01:08 squeezeplay:    [C 0x35bc1]: in function '_eventHandler'
Jan 20 13:01:08 squeezeplay:    /usr/share/jive/jive/ui/Window.lua:1864: in function
Jan 20 13:01:08 squeezeplay: DEBUG  squeezeplay.ui - Widget.lua:452 Action (go) consumed by widget source: [/usr/share/jive/jive/ui/Slider.lua]:108

Debug when Working:

Jan 20 13:11:16 squeezeplay: ERROR  squeezeplay.ui - Widget.lua:446 Calling widget action listener for action: (go) from source: [...r/share/jive/applets/NowPlaying/NowPlayingApplet.lua]:805
Jan 20 13:11:16 squeezeplay: stack traceback:
Jan 20 13:11:16 squeezeplay:    /usr/share/jive/jive/ui/Widget.lua:446: in function 'callback'
Jan 20 13:11:16 squeezeplay:    /usr/share/jive/jive/ui/Widget.lua:656: in function '_event'
Jan 20 13:11:16 squeezeplay:    /usr/share/jive/jive/ui/Window.lua:1890: in function </usr/share/jive/jive/ui/Window.lua:1859>
Jan 20 13:11:16 squeezeplay:    [C 0x2bbe5]: ?
Jan 20 13:11:16 squeezeplay:    [C 0x2b4b5]: in function 'processEvents'
Jan 20 13:11:16 squeezeplay:    /usr/share/jive/jive/ui/Framework.lua:291: in function </usr/share/jive/jiv
Jan 20 13:11:16 squeezeplay: DEBUG  squeezeplay.ui - Framework.lua:770 Translated action title_left_press to back
Jan 20 13:11:16 squeezeplay: DEBUG  squeezeplay.ui - Framework.lua:770 Translated action title_right_press to go_now_playing
Comment 6 SVN Bot 2010-01-20 11:30:31 UTC
 == Auto-comment from SVN commit #8385 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8385 ==

Fixed Bug: 15504
Description: workaround issue with Slider consuming 'go' action by adding the title group widget to the window after the progress bar
Comment 7 Michael Herger 2010-01-24 22:20:08 UTC
*** Bug 15500 has been marked as a duplicate of this bug. ***
Comment 8 Chris Owens 2010-04-08 17:26:46 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!