Bugzilla – Bug 1550
Numeric keypad jumping on Playlists menu is broken
Last modified: 2008-08-18 10:54:16 UTC
I am having a problem with 6.0.2 with the Playlists menu. I don't know what the numeric keypad buttons are doing, but they are definitely not jumping to playlists with the same first letter. For example, I have the following 28 playlists: Bed - Branigan Bed - Lavigne Dance Dice Disney drm Funny Groove Coverage Kill Bill LAME Import LimeWire Mike Riccio's Playlist My Top Rated MyRadio Party Party Shuffle Purchased Music Recently Played Sad Scarlet ShoutcastBrowser_Recently_Played Shuffle Up Stuck Top 25 Most Played Vegas Viva Las Vegas Work Zapped Songs In the Playlists menu, pressing 1 through 4 goes to "ShoutcastBrowser_Recently_Played". The 3rd press of 4 takes me to "Bed - Branigan". 5 through 9 take me to "Viva Las Vegas". Of these playlists, all are iTunes playlists (with prefix and suffix set to ""), except for "ShoutcastBrowser_Recently_Played", "Work", and "Zapped Songs". The keypad buttons work correctly on other menus, such as the Artists menu. My server is actually running on MacOS X 10.4.1, but that wasn't an option in the bugzilla menu.
I'm able to reproduce this with 6.1 on windows as well. No debug flags in this part of code to help. Browse Playlists seems to be coming up as a sorted list, so numbers, I believe should be coresponding to alphabetical reference as oppsed to proportional numeric index. I'm not sure that the server is actually handling playlists as an alpha sorted list (they appear as such, but still use the numeric pagebar). This might be the source of the confusion.
it seems that the player UI isn't sorting the playlist listing like it does in the web UI. This would affect Browse Music Folder as well. I'm not really sure I get why the alpha indexing is done how it is, but given that it seems to be trying to do, adding the following at line 369 of Slim/Buttons/Browse.pm should help: @{$client->dirItems} = Slim::Music::Info::sortByTitles(@{$client->dirItems}); For 6.1, this goes at line 374.
I have a presumably related problem on the Artists menu. All numeric keys jump to the correct letter in the list except for the following (I have at least one artist for every letter of the alphabet): I J K N O U V The Albums menu works fine, and the Playlists menu doesn't respond to the numeric keypad at all.
with the new browse playlist as of the 6.1 nightly build of 6.1 this is mostly fixed. The only error I can find now is if there are no numerical items in the list. the effect is that it seems to take the first A item and use that. so for 1, you get abcaabc, etc. The only place I have this problem is browse playlist since the other modes all have numerical items. I expect the effect is the same since they all use browsedb.
hmm...seems this is really just the numberscroll function taking the closest match possible in any case where the exact match isn't possible. This may be a valid design limit, and is at least a consistent behaviour
Yes, I believe that it now works as designed.
This bug was marked resolved in Slimserver 6.1, which is several versions ago. If you're still seeing this bug, please re-open it. Thanks!