Bug 1547 – bounce up and bounce down animations are backwards? for everything?

Bug 1547 - bounce up and bounce down animations are backwards? for everything?

Summary:

bounce up and bounce down animations are backwards? for everything?

Status:	RESOLVED WONTFIX

Product:	MySqueezebox.com
Classification:	Unclassified
Component:	Player UI
Version:	Prod
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-05-16 16:11 UTC by Kevin Pearsall
Modified:	2008-03-14 08:56 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kevin Pearsall 2005-05-16 16:11:40 UTC

weird.

if you press left on the main menu and it bounces, the text scrolls right.

if you press right on like track information for instance and it bounces, the
text scrolls left.

but if you have an empty playlist, and press up, the text goes up.  isn't this
backwards?  shouldn't the bounce animation be going the opposite way of the
direction you're pushing?

i'm seeing this with slimp3, sb1g, and sb2...

Comment 1 KDF 2005-05-16 16:21:14 UTC

since the scroll up/down animations are just the bottom line in sb2, probably
should just bounce bottom line as well

Comment 2 Adrian Smith 2005-07-01 10:03:25 UTC

Tend to agree with this.  Would be trivial to change round in the server 
display code [leaving the current SB2 firmware].

Perhaps it is best to send a patch to the dev's list to see what people think 
[Dean?]

Comment 3 KDF 2005-07-01 11:43:50 UTC

The bounce animations for SB2 are client-side, so there is little that can be
done without access to firmware.

Comment 4 Adrian Smith 2005-07-01 11:47:32 UTC

I was proposing swapping the direction, not the line2 only bit - appologies 
for lack of clarity  We can swap the direction from the server by renaming the 
function calls!

Comment 5 KDF 2005-07-01 12:36:21 UTC

true.  the drawFrameBuf command sent to SB2 will be the only confusion
remaining.  U for down and D for up :)

Comment 6 Adrian Smith 2005-07-03 14:26:45 UTC

I've changed bumpUp/Down over for all players in r3600.

Please close assuming this looks right...

Comment 7 Kevin Pearsall 2005-07-05 17:08:23 UTC

looks pretty cool to me...  for consistency this should go on squeezenetwork as
well right?

Comment 8 KDF 2005-07-05 21:00:01 UTC

bounce to squeezenetwork for now.  might be nice to finish this off with a
firmware tweak that changes so that:
$client->drawFrameBuf($startbits, undef, 'U', 0);
does bump up
and:
$client->drawFrameBuf($startbits, undef, 'D', 0);
does bump down

just to make complete sense :)

Comment 9 Adrian Smith 2005-07-06 10:53:16 UTC

Push left/right 'r' and 'l' could also be swapped in the firmware and 
softsqueeze if the firmware is changed!

Comment 10 KDF 2005-07-06 11:18:33 UTC

hah! that's funny.  bump LR are fine, push LR are swapped...
bump UD are swapped, but push UD are fine :)

holy vertigo, batman!

Comment 11 Dan Sully 2006-01-19 20:43:22 UTC

Is this still an issue?

Comment 12 Adrian Smith 2006-01-20 09:46:41 UTC

Slimserver has been fixed for a while, this was left open for Softsqueeze [which I don't use so don't know!]

The remaining issue is that the naming of up down left right is wildly inconsitent.  To change this requires a coordinated change to firmware, softsqueeze and the server so I suspect is never going to happen...