Bug 15456 - Album Artist/Track Artist
: Album Artist/Track Artist
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: PC Windows Vista
: P1 normal with 2 votes (vote)
: 7.5.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-11 00:33 UTC by Schindler
Modified: 2010-08-24 01:45 UTC (History)
7 users (show)

See Also:
Category: ---


Attachments
Sinatra Duets album, stripped of music (deleted)
2010-02-16 22:02 UTC, Jim McAtee
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Schindler 2010-01-11 00:33:14 UTC
Hello on my controller (7.5.0 r8307) I only see "album artist" on the same line as the album name.

There is no way to select if I would use track artist there. Now I don't see if there are more than one artist in the currently played song?!

The use of "+" is not really an option here...

On the other devices, as Transporter (ARTIST) does show "track artist" btw.
Comment 1 Chris Owens 2010-02-01 08:15:37 UTC
Steven to review this bug and set a priority and target based on his judgment of how serious it is.
Comment 3 Jim McAtee 2010-02-15 16:41:20 UTC
I believe this is a SqueezePlay bug and affects all SP based players.  I see it also on the Touch.  The two things that are wrong and very different from the web and ip3k player remote interfaces:

1. In a track listing for an album the AlbumArtist is listed for every track, not the TrackArtists.  In the web and ip3k remote interfaces it is:

TrackArtist1 & TrackArtist2 & etc.

2. In the Now Playing and Current Playlist screens only _ONE_ TrackArtist is displayed.  In the web and ip3k remote interfaces all TrackArtists are shown, formatted as above.
Comment 4 SVN Bot 2010-02-15 23:48:17 UTC
 == Auto-comment from SVN commit #30169 to the  repo by mherger ==
 == https://svn.slimdevices.com/?view=revision&revision=30169 ==

Fixed Bug: 15456
Description: use the same artist line logic as on web/classic UI on SP too: Albumartist Trackartists
Comment 5 Michael Herger 2010-02-16 03:21:31 UTC
*** Bug 9633 has been marked as a duplicate of this bug. ***
Comment 6 Jim McAtee 2010-02-16 03:27:58 UTC
Not exactly fixed yet.  Here's are the FLAC tags from a track from a non-compilation album:

comment[0]: Artist=Frank Sinatra
comment[1]: Artist=Luther Vandros
comment[2]: Title=The Lady Is A Tramp
comment[3]: Album=Duets
comment[4]: Genre=Jazz
comment[5]: Genre=Vocal
comment[6]: Albumartist=Frank Sinatra
comment[7]: Albumartistsort=Sinatra, Frank
comment[8]: Date=1993
comment[9]: Tracknumber=1

The following roles are created for this track in the database:

Frank Sinatra, 5 (AlbumArtist)
Frank Sinatra, 6 (TrackArtist)
Luther Vandross, 6 (TrackArtist)

In the track listing for an album it appears correctly:

Frank Sinatra & Luther Vandros

In Now Playing and Current Playlist, however, it's incorrect:

Frank Sinatra, Frank Sinatra, Luther Vandros, Frank Sinatra, Luther Vandros
Comment 7 Michael Herger 2010-02-16 03:37:36 UTC
> In the track listing for an album it appears correctly:
>
> Frank Sinatra & Luther Vandros

Which UI?

> In Now Playing and Current Playlist, however, it's incorrect:
>
> Frank Sinatra, Frank Sinatra, Luther Vandros, Frank Sinatra, Luther  
> Vandros

Yeah, that's not good.
Comment 8 Michael Herger 2010-02-16 03:41:36 UTC
This needs a bit more work
Comment 9 Jim McAtee 2010-02-16 03:46:49 UTC
(In reply to comment #7)

> Which UI?

Touch, Radio and SqueezePlay desktop.
Comment 10 Michael Herger 2010-02-16 04:51:37 UTC
Concatenate 'albumartist', 'trackartist', 'artist' (in this order) in Now Playing area, but every value only once. Use Albumartist on the album level, trackartist or artist on the track level.
Comment 11 Schindler 2010-02-16 04:57:40 UTC
becareful I think "ALBUMARTIST" is not mandatory - but I guess you know that...
Comment 12 SVN Bot 2010-02-16 05:02:24 UTC
 == Auto-comment from SVN commit #30170 to the  repo by mherger ==
 == https://svn.slimdevices.com/?view=revision&revision=30170 ==

Bug: 15456
Description: show whatever of 'albumartist', 'trackartist', 'artist' (in this order, whatever is defined) in Now Playing area, but every value only once. Use Albumartist on the album level,
trackartist or artist on the track level.
Comment 13 Jim McAtee 2010-02-16 14:50:48 UTC
(In reply to comment #12)

> show whatever of 'albumartist', 'trackartist', 'artist' (in this order, whatever is defined) in Now Playing area, but every value only once.

I'm still seeing artists duplicated in the list.  Using the above example, where Frank Sinatra is both the AlbumArtist and a TrackArtist for the track, I get the following in Now Playing and the Current Playlist:

Frank Sinatra, Frank Sinatra, Luther Vandros

I also have one track on the same album (tagged the same way, same roles) which appears:

Frank Sinatra, Barbra Streisand, Frank Sinatra, Barbra Streisand
Comment 14 Michael Herger 2010-02-16 21:38:10 UTC
Jim - please upload a small sample file showing this behaviour. I must be  
doing something wrong tagging my files. They're fine :-)
Comment 15 Jim McAtee 2010-02-16 22:02:14 UTC
Created attachment 6536 [details]
Sinatra Duets album, stripped of music

Try this.  This is the whole album mentioned above, stripped of audio using the flactruncate.pl script from the wiki.
Comment 16 Jim McAtee 2010-02-16 22:10:13 UTC
I guess bugzilla doesn't like zip files(?)  Use this link instead:

http://zolx.com/download/Duets.zip
Comment 17 SVN Bot 2010-02-16 22:49:19 UTC
 == Auto-comment from SVN commit #30180 to the  repo by mherger ==
 == https://svn.slimdevices.com/?view=revision&revision=30180 ==

Bug: 15456
Description: need to split trackartist, as it's already a comma delimited list of the several artists.

Thanks Jim!
Comment 18 Digital Mitch 2010-02-17 02:34:04 UTC
I am not sure that adding "albumartist" to the list of track artists is necessarily the correct fix. I interpreted the original bug being to show all track artists (with some currently missing from multiple tags).

Thre are three cases (from the forums) where showing AlbumArtist in the list would be 'extra and unnecessary' information but not an exact match to any Artist info.

1) Guest Artists
where guest artist and Album Artist are consolidated in one tag (to preserve nature of relationship 'and','featuring','with' et. al.
e.g.
AlbumArtist="Johnny Cash"
Artist="Johnny Cash and Flea"
should only see Track Artist

this could be avoided by multiple tags at expense of relationship detail.

2) Conolsolidating Artist Names 
some use AlbumArtist to show a consistent name where a band/artist has used a variety of names over time. The 'correct' names is kept in Track Artist
e.g. 
AlbumArtist ="Bruce Springsteen"
Artist="Bruce Sprinsteen & the E-Street Band"
Album="Live 1975-85"
should only see Track Artist, but all selection is as Bruce Springsteen

3) Various Artists
some use AlbumArtist to provide granularity for compilations
e.g.
AlbumArtist="Various - Sixties"
AlbumArtist="Various - Seventies"
for each track, should only see Track Artists.

I am not sure how many other people tag like this, but I do and I 'learnt' the techniques from the forums, so there are some others.
Comment 19 Schindler 2010-02-17 03:08:53 UTC
If you have AlbumArtist="Various Artists" or something like this then the COMPILATION Flag should be set and therefore AlbumArtists not visible in Now Playing.

I don't know if it is set somehow like this? But I hope not to see any Various Artists on the Now Playing screen... ;-)

christian
Comment 20 Schindler 2010-02-17 03:10:12 UTC
Anyway this change (bug) is only for new products, maybe it should just behave like the old ones...
Comment 21 Michael Herger 2010-02-17 03:23:37 UTC
> I am not sure that adding "albumartist" to the list of track artists is
> necessarily the correct fix. I interpreted the original bug being to  
> show all track artists (with some currently missing from multiple tags).

Please test the current solution and report how it is broken. It's the  
same we've been using in the web UI for about two years without complaint.
Comment 22 Jim McAtee 2010-02-17 03:44:20 UTC
Thanks Michael.  That last change got it.  Now it's the same as in the web ui.  A little better, actually, as in the web ui I sometimes see repeated artists in Now Playing (but not in album track lists or the Current Playlist).
Comment 23 Digital Mitch 2010-02-17 09:44:09 UTC
check this with SBS Version: 7.5.0 - r30180 and SBC at v7.5.0 r8504

I can still see inconsistencies between SB3, web-gui and SBC but the duplication from r30179 is gone (I've rarely used web gui since I got SBC and not much before that).

I removed all sort fields for the album under test and then did a clear and rescan. All files Flac.
I have looked at 4 displays
SB3
web pop-up (the info line at the bottom of default web screen for 2/3 seconds)
web now playing (top right the detachable window always visbile)
SBC

If a track has multiple Artists and no AlbumArtist then 
SB3 & web pop-up: Artist1 & Artist2 & Artist3
web now playing: Artist1,Artist2,Artist3
SBC: Artist1    ... only

If there is an AlbumArtist then
SB3 & web pop-up: Artist1 & Artist2 & Artist3
web now playing & SBC: AlbumArtist,Artist1,Artist2,Artist3

The original bug still apears when there is no AlbumArtist set {or something else is going on ??}

Personally I prefer the SB3 & web pop-up method (no AlbumArtist) for the reasons outlined in Comment 18 (all three cases verified on SBC)

ASIDE: the actual order of the display is also inconsistent, even between web now playing and SBC, BUT I haven't fully explored that and I'm personally less concerned, but please don't take above as the sort order.
for current track:
web now playing: Artist1,AlbumArtist
SBC: AlbumArtist,Artist1
Comment 24 Schindler 2010-02-17 11:28:00 UTC
Here my example from the post. (with AlbumArtist=Pete Yorn)

I have on the Controller:
Pete Yorn, Scarlett Johannsson . Break Up

in the WEBUI:
1. Relator
Break Up (2009)
Pete Yorn, Scarlett Johansson, Pete Yorn

So Pete Yorn is one too much on the WEBUI

Actually I care more on the Controller where its ok , but just to let you know...

Did not make a rescan of the library.

Version: 7.5.0 - r30180
BS: Windows Vista - DE - cp1252
Plattform: 586
Perl-Version: 5.10.0 - MSWin32-x86-multi-thread
MySQL-Version: 5.0.22-community-nt-log
Comment 25 Alan Young 2010-03-02 03:33:38 UTC
Change for bug 15456 have partly reverted the changes noted in comments 4, 12,  & 17. Only the current track gets the enhanced artist information.
Comment 26 Alan Young 2010-03-02 03:36:25 UTC
I note that the calculation of the primary track artist uses the roles ARTIST and TRACKARTIST in that order of preference. I am unsure if the ARTIST role should be preferred over the TRACKARTIST role for individual tracks. That would depend upon what the SCANER puts in the ARTIST role depending upon various combinations of track tags.
Comment 27 Chris Owens 2010-04-08 17:26:04 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!
Comment 28 Digital Mitch 2010-04-09 06:47:01 UTC
This is now comletely broken for me, as advised in previous comment.
The problem of missing artists from artist list is replaced by duplication due to inclusion of AlbumArtist as well.

Squeezeplay (SBC and Radio) are consistent with webui but NOT with SB3/Boom:-

examples below:-

1) Guest Artists
AlbumArtist="Johnny Cash"
Artist="Johnny Cash and Flea"

webui/SBC/Radio: "Johnny Cash, Johnny Cash and Flea"
SB3/Boom: "Johhny Cash and Flea"

2) Conolsolidating Artist Names 
AlbumArtist ="Bruce Springsteen"
Artist="Bruce Sprinsteen & the E-Street Band"
Album="Live 1975-85"

webui/SBC/Radio: "Bruce Springsteen, Bruce Springsteen & the E-Street Band"
SB3/Boom: "Bruce Springsteen & the E-Street Band"

3) Various Artists
AlbumArtist="Various - Sixties"
Album="A time to Remember 1969"
Track="He Ain't Heavy"
Artist="Hollies"
Compilation="1"

webui/SBC/radio: "Various - Sixties, Hollies"
SB3/Boom: "Hollies"

it may be that SB3 and webui have always been inconsistent and therefore there are multiple expectations.
Comment 29 Digital Mitch 2010-08-24 01:45:53 UTC
(In reply to comment #27)
> This bug has been marked fixed in a released version of Squeezebox Server or
> the accompanying firmware or mysqueezebox.com release.
> 
> If you are still seeing this issue, please let us know!

Chris, still seeing this, as posted in the bug thread (copied below)

Mitch

This is now comletely broken for me, as advised in previous comment.
The problem of missing artists from artist list is replaced by duplication due
to inclusion of AlbumArtist as well.

Squeezeplay (SBC and Radio) are consistent with webui but NOT with SB3/Boom:-

examples below:-

1) Guest Artists
AlbumArtist="Johnny Cash"
Artist="Johnny Cash and Flea"

webui/SBC/Radio: "Johnny Cash, Johnny Cash and Flea"
SB3/Boom: "Johhny Cash and Flea"

2) Conolsolidating Artist Names 
AlbumArtist ="Bruce Springsteen"
Artist="Bruce Sprinsteen & the E-Street Band"
Album="Live 1975-85"

webui/SBC/Radio: "Bruce Springsteen, Bruce Springsteen & the E-Street Band"
SB3/Boom: "Bruce Springsteen & the E-Street Band"

3) Various Artists
AlbumArtist="Various - Sixties"
Album="A time to Remember 1969"
Track="He Ain't Heavy"
Artist="Hollies"
Compilation="1"

webui/SBC/radio: "Various - Sixties, Hollies"
SB3/Boom: "Hollies"

it may be that SB3 and webui have always been inconsistent and therefore there
are multiple expectations.