Bug 15380 - Slim/Web/HTTP: return the proper stream Content-Type
: Slim/Web/HTTP: return the proper stream Content-Type
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Streaming From SlimServer
: 7.4.1
: All Fedora
: P3 minor (vote)
: 7.4.2
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-29 13:46 UTC by Andrew
Modified: 2009-12-29 14:08 UTC (History)
1 user (show)

See Also:
Category: Bug


Attachments
0001-Slim-Web-HTTP-return-the-proper-stream-Content-Type.patch (1.43 KB, patch)
2009-12-29 13:46 UTC, Andrew
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew 2009-12-29 13:46:04 UTC
Created attachment 6409 [details]
0001-Slim-Web-HTTP-return-the-proper-stream-Content-Type.patch

The stream URI is always "/stream.mp3", which makes the
generateHTTPResponse() method assume that the Content-Type must be
"audio/mpeg" (according to typeFromSuffix()).  The method does not
check which kind of file is really being served, breaking strict music
players (such as the Music Player Daemon).  This patch checks the song
URL, and re-checks it with typeFromSuffix(), overriding the previous
uninformed guess.

I attached a patch to fix this.
Comment 1 SVN Bot 2009-12-29 14:08:59 UTC
 == Auto-comment from SVN commit #29704 to the slim repo by andy ==
 == https://svn.slimdevices.com/slim?view=revision&revision=29704 ==

Fixed bug 15380, patch from agillis to use proper content-type on streaming response