Bug 15362 - normalize_location changes each path twice, so iTunes playlists fail
: normalize_location changes each path twice, so iTunes playlists fail
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.4.1
: PC Windows XP
: -- normal (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-22 15:20 UTC by Joel
Modified: 2010-01-14 08:54 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
Edited scanner log. RTF so I could color-code the area where the problem occurs. (10.19 KB, application/msword)
2009-12-22 15:20 UTC, Joel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joel 2009-12-22 15:20:12 UTC
Created attachment 6403 [details]
Edited scanner log. RTF so I could color-code the area where the problem occurs.

In the attached scanner log, Slim::Plugin::iTunes::Common::normalize_location
can be seen to operate *twice* on each song path.  The first instance (shown in
green) correctly changes the path from //localhost/M: to //Homeserver/music,
but this is followed by a second instance (in red) that changes it back.  The
result is that playlist scan can't find any of the music files, although they
all play fine when selected from Artists, Albums, etc.

SBS 7.4.1 on WHS box, with iTunes enabled, and no playlist library path
specified.  Everything works except that the "playlists" choice doesn't appear
in the web GUI.
Comment 1 m1lk0 2010-01-08 01:41:10 UTC
Did you add the iTunes Music Folder or the iTunes Media Folder? I had the same problem (see: http://forums.slimdevices.com/showthread.php?p=504095#post504095, I can translate it, if you're not German). First I added "only" the iTunes Music folder and got similar logs like you. After ich checked the log-paths I recognized that there was the /music folder added twice (/music/music). Then I changed the iTunes paths in SQZ iTunes Tab to the iTunes Media folder and everything was fine.
Comment 2 Michael Herger 2010-01-08 02:22:56 UTC
There's been a tiny change in recent iTunes versions: what we call the "iTunes Music Folder" has in iTunes been renamed to "iTunes Media Folder". 

Joel - if you changed this prefernce in SBS accordingly, would it work?

Please double check the file paths you considered correct:

////Homeserver/music/Music/Music/(hed)%20Planet%20Earth/Blackout/01%20Suck%20It%20Up.mp3

probably should be 

////Homeserver/music/Media/Music/(hed)%20Planet%20Earth/Blackout/01%20Suck%20It%20Up.mp3

or similar instead
Comment 3 SVN Bot 2010-01-08 23:41:25 UTC
 == Auto-comment from SVN commit #29757 to the slim repo by michael ==
 == https://svn.slimdevices.com/slim?view=revision&revision=29757 ==

Bug: 15362
Description: change iTunes terminology to match Apple's
Comment 4 Joel 2010-01-11 22:16:03 UTC
Michael:

Yes, thanks, you've solved my problem.  Sorry for the head-fake ;^).  Not sure I understand the following comment, but it does seem that changing the terminology to follow Apples' is needed.  

Going further, detecting and preventing misconfiguration is a big part of keeping users happy and out of developers' hair -- wondering if this sort of situation might be rather easily detectable, and whether some sort of message telling the user what to do about it might be a good thing.  

Philosopically, I think it may be better to just fail completely with an informative error message than try to do something on your own that doesn't always work, and doesn't tell the user what's happening when it doesn't work.

Thanks again.

J
Comment 5 Michael Herger 2010-01-11 23:24:48 UTC
> Philosopically, I think it may be better to just fail completely with an
> informative error message than try to do something on your own that doesn't
> always work, and doesn't tell the user what's happening when it doesn't work.

Isn't this what it's doing right now? Failing completely?

Thanks for the feedback. I've updated the description to use the new terminology. Localisations should be available in a few weeks.
Comment 6 Joel 2010-01-14 08:54:24 UTC
(In reply to comment #5)
> > Philosopically, I think it may be better to just fail completely with an
> > informative error message than try to do something on your own that doesn't
> > always work, and doesn't tell the user what's happening when it doesn't work.
> 
> Isn't this what it's doing right now? Failing completely?
> 
> Thanks for the feedback. I've updated the description to use the new
> terminology. Localisations should be available in a few weeks.

Michael:

No, I don't think so at all:  To review, I gave SBS a correct path to the iTunes database, but an incorrect path to the music itself.  In spite of this (apparently very fundamental) misconfiguration, SBS found and played my music happily.  I was able to see all of the Artists, Albums, etc. etc.  Only the playlists mysteriously disappeared from the UI.  No note about why they were suddenly gone or anything.  I had no reason to suspect I'd failed to point SBS at my library, since it was playing my library happily.

So, I think it may have been better to just refuse to do anything, give an informative error message ("I can't find your music lib. at the location specified").

Thanks again.

Best,  J