Bug 15339 - Pandora: Buttons on the remote don't work properly
: Pandora: Buttons on the remote don't work properly
Status: CLOSED FIXED
Product: SB Touch
Classification: Unclassified
Component: App Gallery
: unspecified
: PC Other
: P1 normal (vote)
: 7.5.0
Assigned To: Ben Klaas
: partner_important
Depends on: 15573
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-18 15:03 UTC by Vic Wong
Modified: 2010-04-08 17:24 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vic Wong 2009-12-18 15:03:17 UTC
Some buttons on the remote (up, down, right arrows) cause audio skips and cut-outs.
Comment 1 Chris Owens 2010-01-19 17:20:10 UTC
On the now playing screen, down arrow appears to be a rewind function.  Up arrow appears to be ffwd.  I'm not sure what right arrow thinks it's doing, but it doesn't work.

Vic, do I recall correctly that rewind and ffwd should be disabled for Pandora?  If so, I will just get these commands disabled during Pandora use.

Thanks for any info!
Comment 2 Vic Wong 2010-01-20 10:47:46 UTC
For Pandora: rewind and ffwd should not be available. By ffwd I assume you don't mean "skip" which should be available. "skip backward" should NOT be available.
Comment 3 Chris Owens 2010-02-02 14:33:04 UTC
QA to retest this after Ben's recent changes
Comment 4 Mickey Gee 2010-02-05 11:14:01 UTC
I will file new bug for skip not working when using remote.
Comment 5 Mickey Gee 2010-02-11 16:35:14 UTC
On r8470 firmware, here's what happens:

Right arrow: Audio skip or cut-out
Down arrow: Audio skip or cut-out
Up arrow: Audio skip or cut-out
Left arrow: Goes back to previous screen

REW button: Nothing
FWD button: Audio skip or cut-out

Here's what happens on Radio and should happen on Touch:

Right arrow: On Radio, brings up Pandora context menu (I like this song, etc.). Think this should happen on Touch too.
Down arrow: Nothing
Up arrow: Nothing
Left arrow: Goes back to previous screen. Also brings down Pandora context menu.

REW button: Nothing
FWD button: Skip to next track

No need to file new bug -- have re-titled and changed this one.
Comment 6 Ben Klaas 2010-02-16 08:58:51 UTC
Bug 15573 is very closely tied to this. It's likely to be one fix for both bugs.
Comment 7 Ben Klaas 2010-02-16 12:30:10 UTC
For clarity, this is not a Touch only issue and comment #5 is incorrect in saying that it works in Radio. This can be reproduced in Radio as easily as Touch, but on neither platform is it a 100% reproducible issue.

Steps to reproduce:
1. Play a Pandora station
2. Verify that + button or right arrow will bring up context menu
3. Navigate back and select another Pandora station
4. Verify that + button or right arrow does not bring up CM and causes audio to skip

mapping of actions in NP applet appears broken under certain conditions.
Comment 8 Ben Klaas 2010-02-16 13:09:48 UTC
100% of the window listeners are lost under certain conditions, including in the previous comment.

There is nothing in the code to remove those window listeners, so there must be an underlying lower level bug causing the linkage of the listeners to the window to be lost.

Still investigating...
Comment 9 Ben Klaas 2010-02-16 13:17:31 UTC
Further info, it's the use of this code that causes the listeners to be lost:

    if not self.snapshot then
                self.snapshot = SnapshotWindow()
        else
                self.snapshot:refresh()
        end
        --temporarily swap in snapshot window of previous track window to allow for fade transition in to new track
        self.snapshot:replace(self.window)
        self.window:replace(self.snapshot, _nowPlayingTrackTransition)
Comment 10 Ben Klaas 2010-02-16 13:29:45 UTC
Ignore comment #9, I've reproduced the issue with that code block commented out.
Comment 11 Ben Klaas 2010-02-16 13:54:19 UTC
I've determined the self.window listeners table in NowPlayingApplet is not lost by the applet, even after this behavior is seen. Still unknown why the actions in the window listeners are not being obeyed.
Comment 12 Ben Klaas 2010-02-16 14:43:50 UTC
another data point-

I turned my attention to _updateButtons() and disabled it as a debug to see whether any of the calls in that method are the cause of the issue. This includes things like remapping button styles and callbacks, replacing window widgets with other widgets, etc.

The problem is fully reproducible when the _updateButtons is disabled.
Comment 13 SVN Bot 2010-02-17 10:01:48 UTC
 == Auto-comment from SVN commit #8518 to the  repo by bklaas ==
 == https://svn.slimdevices.com/?view=revision&revision=8518 ==

Fixed Bug: 15339
Fixed Bug: 15573
Description: fully replace NP window on track change. This is a workaround to the fact that window listeners are being lost in particular situations (e.g., a new pandora station being selected and updating an already drawn NP window).
add log debug messages in notifications
don't take action on notifications not intended for the current player
restyle the rbutton widget rather than replace the whole title group widget set
Comment 14 Chris Owens 2010-04-08 17:24:30 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!