Bugzilla – Bug 15334
Pandora: Thumbs should be disabled on shared stations
Last modified: 2010-04-08 17:25:53 UTC
Thumbs buttons are still available on the screen. They should be greyed out for shared stations. Also, be sure to handle the case where a song is playing from a shared station while listening to a quickmix. The client should check the 'allowFeedback' flag of the track to see if rating is allowed
Vic notes the song has an 'isRatable' attribute than should be used to determine if it's ratable. Maybe we could just replace the thumbs-up, thumbs-down icon with an information text that says 'this song is not ratable'
the attribute is actually "allowFeedback".
We first need grayed-out thumb button artwork. Who does artwork now Chris?
We do have disabled thumb artwork. If the metadata is coming to the client, this can be mine to fix.
This is the dump of metadata received by squeezeplay for a shared station. There is nothing received denoting 'allowFeedback'. Server-side issue Andy? { --[[table: 0x17a5aa20]] album = "Petestrumentals", title = "For The People", buttons = { --[[table: 0x17a5aa60]] fwd = 1, repeat = { --[[table: 0x17a5ac00]] command = { --[[table: 0x17a5aec0]] "pandora", "rate", 1, }, tooltip = "I like this song", jiveStyle = "thumbsUp", icon = "html/images/btn_thumbs_up.gif", }, shuffle = { --[[table: 0x17a5ab70]] command = { --[[table: 0x17a5abe0]] "pandora", "rate", 0, }, tooltip = "I don't like this song", jiveStyle = "thumbsDown", icon = "html/images/btn_thumbs_down.gif", }, rew = 0, }, id = "-203889468", duration = "262", artist = "Pete Rock", }
IMO, what should be happening on the server side is a determination that rating is not allowed, and if it's not I should be receiving this in the button metadata shuffle = { jiveStyle = 'thumbsDownDisabled', ... } and repeat = { jiveStyle = 'thumbsUpDisabled', ... } AFAICT, the icon and toolTip data in the dump listed in the last comment are not used by squeezeplay.
OK I can add that.
Just as an FYI, there will be Squeezeplay-side changes to accomodate this bug as well. Assign back to me after the server-side change.
== Auto-comment from SVN commit #30022 to the slim repo by andy == == https://svn.slimdevices.com/slim?view=revision&revision=30022 == Bug 15334, send disabled artwork flag when Pandora track can't be rated
== Auto-comment from SVN commit #8466 to the repo by bklaas == == https://svn.slimdevices.com/?view=revision&revision=8466 == Bug: 15334 Description: styles for thumbsDownDisabled and thumbsUpDisabled
fixed with Andy's r30092 checkin on the server side
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release. If you are still seeing this issue, please let us know!