Bug 1532 - disabled plugins added to prefs repeatedly
: disabled plugins added to prefs repeatedly
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugins
: 6.1.0
: PC All
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-05-12 14:36 UTC by KDF
Modified: 2008-09-15 14:37 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2005-05-12 14:36:53 UTC
ons starterup, initPlugin will push disabled plugins to the disabledplugins
prefs, regardless of whether they are already in teh prefs.  Thus you end up
with thousands of copies in the prefs.  bad bad bad bad.

instead, check if the plugin is already disabled and dont process it at all.

139a140,141
> 		next if exists $disabledplugins{$plugin};
>
Comment 1 KDF 2005-05-12 14:40:59 UTC
oh yeah...to clear up for people who have already fallen victim to this, they
just have to go into server settings->plugins and change a plugin enable/disable
setting.  That should wipe the array clean and rebuild.

someone will need to test this aside from me, and I think michael is away now
(ie, Dan, I hope you have a few minutes)

Comment 2 Dan Sully 2005-05-12 14:47:47 UTC
Looks good here.
Comment 3 KDF 2005-05-12 14:58:38 UTC
ok, I'll commit sometime before build.  I dont know if 6.0.x is affected, but
I'll check.  
Comment 4 KDF 2005-05-12 19:35:59 UTC
committed to trunk in change 3167
does not affect 6.0.x

incorrectly marked in svn comment as bug 1523
Comment 5 Michael Herger 2005-05-13 01:30:42 UTC
We have to go through all the add*() procedures to correctly remove the plugins from the menus etc. 
Checked in change 3170 which should do this.
Comment 6 Chris Owens 2006-06-16 14:41:16 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.