Bug 15255 – [Patch] Update to latest version of Class::XSAccessor and eliminate use of private APIs

Bug 15255 - [Patch] Update to latest version of Class::XSAccessor and eliminate use of private APIs

Summary:

[Patch] Update to latest version of Class::XSAccessor and eliminate use of pr...

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Misc
Version:	unspecified
Platform:	All All

Importance:	P3 normal with 1 vote (vote)
Target Milestone:	7.5.0
Assigned To:	Andy Grundman

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-12-06 11:25 UTC by chocolateboy
Modified:	2010-04-08 17:26 UTC (History)
CC List:	4 users (show)

See Also:
Category:	Task

Attachments
Class::XSAccessor 1.05 update (3.41 KB, patch) 2009-12-06 11:25 UTC, chocolateboy	Details \| Diff
Fixed patch: call import as a method rather than a sub (3.52 KB, patch) 2009-12-06 11:32 UTC, chocolateboy	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description chocolateboy 2009-12-06 11:25:24 UTC

Created attachment 6360 [details]
Class::XSAccessor 1.05 update

The attached patch:

  1) updates the (optional) Class::XSAccessor dependency to the latest version
(1.05), which combines the hash and array implementations, improves the API,
and significantly boosts performance.
  2) Eliminates calls to private/undocumented Class::XSAccessor APIs.

The patch is made against SVN HEAD.

Note: the patch doesn't update the files in vendor/CPAN.

Comment 1 chocolateboy 2009-12-06 11:32:46 UTC

Created attachment 6362 [details]
Fixed patch: call import as a method rather than a sub

Fix: call import as a method rather than a sub.

Comment 2 Chris Owens 2009-12-07 09:36:32 UTC

Andy, is this important enough to put into 7.5.0?

Comment 3 Chris Owens 2010-01-25 18:08:49 UTC

Michael, do you have an opinion on how urgent this patch is?  Thanks!

Comment 4 Michael Herger 2010-01-28 03:08:18 UTC

Not really a bug, not a showblocker.

Comment 5 SVN Bot 2010-02-17 09:37:34 UTC

 == Auto-comment from SVN commit #30187 to the  repo by agrundman ==
 == https://svn.slimdevices.com/?view=revision&revision=30187 ==

Fixed bug 15255, use public Class::XSAccessor API

Comment 6 Chris Owens 2010-04-08 17:26:46 UTC

This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!