Bug 15249 - homepage position incorrectly requests title
: homepage position incorrectly requests title
Status: CLOSED FIXED
Product: MySqueezebox.com
Classification: Unclassified
Component: Web UI
: Prod
: All All
: P1 normal (vote)
: 7.5.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-04 14:02 UTC by Matthew J. Martin
Modified: 2010-04-08 17:24 UTC (History)
4 users (show)

See Also:
Category: Bug


Attachments
nothing but depressing emptiness (23.36 KB, image/png)
2009-12-08 08:30 UTC, Michael Herger
Details
Facebook icon file (30.32 KB, image/x-png)
2010-02-16 10:28 UTC, Sarah Waldmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew J. Martin 2009-12-04 14:02:52 UTC
Laura has updated the Queen Exclusive block to be something new. However, it throws an error when she switches it with the new asset in CMS since MySB is requesting the title, when it should just ask for position:

HOME-FEATURE-BOX_ONEFOURTH-WIDTH_LEFT-TO-RIGHT_FOURTH_HALFHEIGHT_TOP-TO-BOTTOM_FIRST 

Please remove the 'title' parameter from the request and only request this position identifier.
Comment 1 Michael Herger 2009-12-08 04:56:32 UTC
?!? If the 'title' flag is only in the title. If I remove it, I get the same content in the title as in the box - which is nothing more than the icon.

Where should I see what content?
Comment 2 Matthew J. Martin 2009-12-08 08:11:16 UTC
To clarify, do not explicitly request "Queen Exclusive", rather just request the position:


instead of:

[% box_title = "Queen Exclusive" | cms('HOME-FEATURE-BOX_ONEFOURTH-WIDTH_LEFT-TO-RIGHT_FOURTH_HALFHEIGHT_TOP-TO-BOTTOM_FIRST', 'title') %]
[% box_width = 240 %]
[% WRAPPER roundedBox %]
	[% "Queen Exclusive" | cms('HOME-FEATURE-BOX_ONEFOURTH-WIDTH_LEFT-TO-RIGHT_FOURTH_HALFHEIGHT_TOP-TO-BOTTOM_FIRST') %]
[% END %]

it should be something like:

[% box_title = cms('HOME-FEATURE-BOX_ONEFOURTH-WIDTH_LEFT-TO-RIGHT_FOURTH_HALFHEIGHT_TOP-TO-BOTTOM_FIRST', 'title') %]
[% box_width = 240 %]
[% WRAPPER roundedBox %]
	[% cms('HOME-FEATURE-BOX_ONEFOURTH-WIDTH_LEFT-TO-RIGHT_FOURTH_HALFHEIGHT_TOP-TO-BOTTOM_FIRST') %]
[% END %]

Basically we shouldn't be requesting specific names of anything except for Apps, which really do need specific names. Other stuff should request positions only so Laura Nelson can switch it in CMS and make it go live as needed.
Comment 3 Michael Herger 2009-12-08 08:30:07 UTC
Created attachment 6369 [details]
nothing but depressing emptiness

Matthew - if I remove those titles I get nothing but empty boxes
Comment 4 Michael Herger 2010-02-15 00:23:54 UTC
I don't know what the issue is, Matthew wasn't able to clarify in his last weeks with logitech. I therefore doubt this is serious.
Comment 5 Sarah Waldmann 2010-02-16 10:05:19 UTC
We wanted to change the Queen icon to the Facebook icon. We couldn't do this from interpire based on it requesting the title instead of the icon image. This bug is still important to update at least the partner well with different partner icons.
Comment 6 Michael Herger 2010-02-16 10:16:20 UTC
Laura - please let me know what you want to have there. We won't be able to fix the CMS interface. Matthew's gone and nobody else knows that code. But we can just replace the contennt with something else, if you let me know what it should be. Should there be some text with the icon, or just the icon only? A link?
Comment 7 Sarah Waldmann 2010-02-16 10:28:20 UTC
Created attachment 6535 [details]
Facebook icon file
Comment 8 Sarah Waldmann 2010-02-16 10:29:46 UTC
Michael - 

Thank you! Can you please help me change the Queen icon to the Facebook icon? I have added it as an attachment. The word Facebook should be above it as a title. 

Thanks,
Laura
Comment 9 Michael Herger 2010-02-16 21:24:49 UTC
Thanks Laura, that should be simple enough. What's the timeframe for this change? Is 7.5 good enough?
Comment 10 SVN Bot 2010-02-16 21:29:45 UTC
 == Auto-comment from SVN commit #7984 to the  repo by mherger ==
 == https://svn.slimdevices.com/?view=revision&revision=7984 ==

Bug: 15249
Description: replace Queen with Facebook icon/link
Comment 11 Michael Herger 2010-02-16 21:32:37 UTC
Done on http://test.mysqueezebox.com - please let me know if you want this to be rolled out to production before the 7.5.0 release.
Comment 12 Sarah Waldmann 2010-02-17 08:45:06 UTC
Hi Michael - 

This is perfect! I would be great to have it go live sooner than 7.5 but if its too much work or makes more sense for 7.5 please let me know. The Queen icon has been there for so long, that a partner change to the homepage would be good.

Thanks,
Laura
Comment 13 Chris Owens 2010-04-08 17:24:37 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!