Bug 15245 - Performing a firmware update should stop TinySC
: Performing a firmware update should stop TinySC
Status: CLOSED FIXED
Product: SB Touch
Classification: Unclassified
Component: TinySC
: 7.5.0
: Other Debian Linux
: P2 normal (vote)
: 7.5.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-03 22:20 UTC by Andy Grundman
Modified: 2010-04-08 17:24 UTC (History)
4 users (show)

See Also:
Category: Task


Attachments
stop samba and SBS before the firmware ugrade (473 bytes, patch)
2010-01-07 02:58 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2009-12-03 22:20:18 UTC
I did a firmware update from my USB drive while it was being scanned, so it 
took quite a bit longer than usual to copy the file.  I think when you start a 
firmware update it should just stop TinySC and maybe other background processes 
like Samba.

Not going to call this a P1 as everything still worked fine.
Comment 1 Michael Herger 2010-01-07 02:58:25 UTC
Created attachment 6424 [details]
stop samba and SBS before the firmware ugrade

Very simple approach, but worked perfectly fine here.
Comment 2 SVN Bot 2010-01-11 00:57:58 UTC
 == Auto-comment from SVN commit #8311 to the jive repo by michael ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8311 ==

Fixed Bug: 15245
Description: stop SBS/Samba before starting the update to free some memory and CPU cycles
Comment 3 Michael Herger 2010-01-22 02:50:13 UTC
Just noticed my fab4 was still getting stuck at 99% downloading, and the download being awfully slow. Logged in to the device and saw that TinySC was still running. 

Ben - could you please review the change I had checked in? Is this being triggered before or after the download?
Comment 4 Ben Klaas 2010-01-22 07:29:57 UTC
I reviewed your code again and it looks fine.

I also tested your code and slimserver.pl was correctly stopped before the download happened.

Not sure how to reproduce this, as it appears to be working for me...

suggest you have a terminal open to the Fab4 when doing software updates.

I see this immediately on the console
# Scanner is not running
Stopping Squeezebox Server
Stopping Samba

and the process in the ps list is removed afterwards...
Comment 5 SVN Bot 2010-01-27 02:31:00 UTC
 == Auto-comment from SVN commit #8410 to the jive repo by michael ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8410 ==

Fixed Bug: 15245
Description: try harder to shut down SBS before the update, use squeezeos.kill() if os.execute() fails to stop it. This might help with bug 15522 too.
Comment 6 SVN Bot 2010-01-27 04:28:55 UTC
 == Auto-comment from SVN commit #8412 to the jive repo by michael ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8412 ==

Bug: 15245
Description: try reading the pid from /var/run
Comment 7 Chris Owens 2010-04-08 17:24:24 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!