Bug 15234 - Choose Player no longer works
: Choose Player no longer works
Status: CLOSED FIXED
Product: SB Touch
Classification: Unclassified
Component: API
: unspecified
: PC Windows XP
: P1 normal with 1 vote (vote)
: 7.5.0
Assigned To: Felix Mueller
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-02 13:05 UTC by Toby
Modified: 2010-04-08 17:26 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
better upload as an attachment... (2.08 KB, text/plain)
2009-12-04 01:37 UTC, Michael Herger
Details
messages file from my controller (29.96 KB, application/octet-stream)
2009-12-04 21:24 UTC, Mikael Nyberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toby 2009-12-02 13:05:42 UTC
r8175

Choose Player does not properly gain control of the other selected player.
Choose Player screen background changes to selected Wallpaper for the selected player, but the check mark does not show the selected player.
After choosing the other player to control, if you go to Favorites it displays a library switch option.
Comment 1 Michael Herger 2009-12-04 01:34:31 UTC
Confirmed: Touch was selected device, trying to connect to Boom:

Dec  4 10:32:46 squeezeplay: INFO   squeezebox.server - SlimServer.lua:691 connected Michael Hergers Mac mini
Dec  4 10:32:46 squeezeplay: INFO   squeezebox.server - SlimServer.lua:691 connected Der edle Zwerg
Dec  4 10:32:47 squeezeplay: INFO   squeezebox.server - SlimServer.lua:314 Michael Hergers Mac mini firmware=http://192.168.0.47:9000/firmware/fab4_7.5.0_r8176.bin force=false
Dec  4 10:32:47 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:420 _menuSink(48) SlimServer {Michael Hergers Mac mini} menuDirective: nil isCurrentServer:nil
Dec  4 10:32:47 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:535 Eliminated myMusic node from server, since now handled locally
Dec  4 10:32:47 squeezeplay: INFO   squeezebox.server - SlimServer.lua:314 Der edle Zwerg firmware=http://192.168.0.254:9000/firmware/fab4_7.5.0_r8176.bin force=false
Dec  4 10:32:47 squeezeplay: INFO   applet.SelectPlayer - SelectPlayerApplet.lua:248 select player item: Player {Boom}
Dec  4 10:32:47 squeezeplay: INFO   applet.SlimDiscovery - SlimDiscoveryApplet.lua:623 selected Boom
Dec  4 10:32:47 squeezeplay: INFO   squeezeplay.applets - AppletManager.lua:708 store settings: SlimDiscovery
Dec  4 10:32:47 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:1028 SlimMenusApplet:notify_playerCurrent(Player {Boom})
Dec  4 10:32:47 squeezeplay: WARN   squeezeplay.ui.draw - jiveL_dispatch_event:762 error in event function:
Dec  4 10:32:47 squeezeplay: 	/usr/share/jive/jive/ui/SimpleMenu.lua:361: assertion failed!
Dec  4 10:32:47 squeezeplay: stack traceback:
Dec  4 10:32:47 squeezeplay: 	[C 0x656a8]: in function '_assert'
Dec  4 10:32:47 squeezeplay: 	/usr/share/jive/jive/ui/SimpleMenu.lua:361: in function 'getItem'
Dec  4 10:32:47 squeezeplay: 	/usr/share/jive/jive/ui/HomeMenu.lua:433: in function 'removeItemFromNode'
Dec  4 10:32:47 squeezeplay: 	/usr/share/jive/jive/ui/HomeMenu.lua:458: in function 'removeItem'
Dec  4 10:32:47 squeezeplay: 	...usr/share/jive/applets/SlimMenus/SlimMenusApplet.lua:1251: in function 'free'
Dec  4 10:32:47 squeezeplay: 	...usr/share/jive/applets/SlimMenus/SlimMenusApplet
Comment 2 Michael Herger 2009-12-04 01:37:44 UTC
Created attachment 6354 [details]
better upload as an attachment...
Comment 3 SVN Bot 2009-12-04 08:04:47 UTC
 == Auto-comment from SVN commit #8186 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8186 ==

Bug: 15234 
Description: Make "Choose Player" work again on Fab4 
- There's still an underlying issue where menu nodes are removed twice. (Most likely because 'SetCurrentPlayer' is called twice.)
Comment 4 Felix Mueller 2009-12-04 08:06:42 UTC
The proper solution needs more investigating.
Comment 5 Mikael Nyberg 2009-12-04 21:24:57 UTC
Created attachment 6359 [details]
messages file from my controller

This is not only fab4 i had this on my controller now

Uploaded the mesages file for you to see, nothing in sbs logs
Comment 6 Toby 2009-12-05 05:40:25 UTC
It's across the entire platform, Radio has exact same symptoms.
Comment 7 Mikael Nyberg 2009-12-05 05:43:09 UTC
And now the fix is in the 7.5 nightly ,so it's working for me again.
Comment 8 Toby 2009-12-06 06:32:40 UTC
SBS 7.5.0 - r29551  Sun Dec 6

Touch r8197 is working

Radio r8176 is NOT working
Comment 9 Michael Herger 2009-12-06 07:47:25 UTC
> Radio r8176 is NOT working

Felix' change was 8186, wasn't it ;-)
Comment 10 Felix Mueller 2009-12-17 03:41:08 UTC
Hmm, I cannot recreate the situation I described in comment #3. :(

Anyways, the issue is resolved so I am going to close the bug.
Comment 11 Chris Owens 2010-04-08 17:26:04 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!