Bug 15188 - Plugins can be updated even when automatic plugin updates is turned off
: Plugins can be updated even when automatic plugin updates is turned off
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugins
: 7.5.0
: PC Windows XP
: P3 normal (vote)
: 7.5.0
Assigned To: Adrian Smith
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-25 00:35 UTC by Philip Meyer
Modified: 2010-04-08 17:25 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Meyer 2009-11-25 00:35:26 UTC
I created a new test environment for 7.5.0 embedded branch, using a copy of my old 7.5 preferences dir, but I pointed to a new cache folder, so I didn't have any third-party plugins installed from Extension Downloader.

When I started the new version of the server, the bottom of the WebUI page reported a notification that "Plugin updates are available".  I can't click this to go to plugins page (seems an obvious thing to expect to happen, like scanner progress message takes you to the scanner progress info page).

But why did it say that plugin updates are available?  I didn't have any installed third-party plugins at this stage.

I navigated manually to Settings > Plugins, and it immediately said "Please restart Squeezebox Server for the changes to take effect", even though "Update plugins automatically" is unticked.
Comment 1 Philip Meyer 2009-11-25 00:36:42 UTC
And having told me that it had updated plugins and that a restart was necessary within the Settings > Plugins window, when I returned to the main Squeezebox Server WebUI window, it didn't update the "Plugin updates are available" info message.  NB. even if I shut down the server and restart it, the main window will still show this message.

If I manually refresh the window, it does then change to "Plugins have been updated - Restart Required".
Comment 2 Adrian Smith 2009-11-30 11:10:36 UTC
I think you will see a plugins need update message if your prefs are out of sync with the installed plugin - could this be the case here? - the prefs says you have plugins X, Y, Z installed but you don't actually have any of them.
Comment 3 Philip Meyer 2009-11-30 12:10:23 UTC
Yes, that's correct.  I did a new SVN checkout, and copied my existing prefs into the new configuration.

I assume that as auto plugin updates is turned off, it should tell me that plugin updates are available, but then just highlight the plugins that need to be installed, and let me decide which ones to install or remove.
Comment 4 Adrian Smith 2009-12-01 14:54:15 UTC
OK I see this..
Comment 5 SVN Bot 2009-12-12 06:23:01 UTC
 == Auto-comment from SVN commit #29598 to the slim repo by adrian ==
 == https://svn.slimdevices.com/slim?view=revision&revision=29598 ==

Bug: 15188
Description: avoid installing plugins immediately the extension downloader page is visited if the prefs are out of sync with installed plugins.  add message on home page that server needs restart once plugin has been selected for install/removal
Comment 6 Adrian Smith 2009-12-12 06:25:07 UTC
change 29598 delays when plugins are installed if the prefs say they are installed but they are not there.  In this case you now need to select update for them to install.  Note there is a limitation - if you want to remove the prefs, then you need to install and then remove the plugin.

Also added a message on the home page when restart is required
Comment 7 Chris Owens 2010-01-04 15:22:22 UTC
Should I mark this resolved, then?
Comment 8 Chris Owens 2010-01-04 16:00:30 UTC
Changing priorities due to management guidance.
Comment 9 Adrian Smith 2010-01-05 12:01:57 UTC
Marking as resolved - I believe it is fixed and based on no feedback to the contary marking as fixed.  Phil, please reopen if you think otherwise.
Comment 10 Chris Owens 2010-04-08 17:25:18 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!