Bugzilla – Bug 1516
search on the player crashes slimserver
Last modified: 2008-09-15 14:37:04 UTC
From the forum: > Since nightly-build 2005_05_06 (the one i see this first) SS crashes on > my linux-box (cent-os 3.4) if use the search function from SB. > > slimserver.pl --diag reports the following: > > Can't use string ("*TOP*") as an ARRAY ref while "strict refs" in use > at > /usr/local/slimserver/Slim/Buttons/BrowseDB.pm line 506 (#1) > (F) Only hard references are allowed by "strict refs". Symbolic > references are disallowed. See perlref. Additionally search for song crashes in Web/Pages: Can't use string ("*GROW*") as an ARRAY ref while "strict refs" in use at /home/mh/eclipse/SVN/Slim/Web/ Pages.pm line 75.
Created attachment 502 [details] Don't crash on album/artist search Too simple to be true, but this might help for artists and albums.
Created attachment 503 [details] fix song search Was there any reason the search term was handled as an array for title search only? If not - this patch might fix the search from player interface crash.
the change you have made to pages, also occur in Pages::Search() be sure to test web UI searches as well with these changes.
I checked them, too (livesearch, advanced and standard). And, hey, it worked.
for me the fix only work for album and artists - not for songs ...
Daniel, did you try the second patch? Could you send the last lines of your slimserver's log before the crash?
This one is very strange... As I did not find any change I could set in relation to this problem I wanted to do a diff between the two nightlies where the behaviour changed. I went back to the oldest still available (05- 01) - and it crashed. As the 04-29 on my server is running fine, I copied it over to my dev machine. And guess what? It crashes on this machine, too! My server is running perl 5.8.6 (home brew), the dev machine 5.8.5 (Mandrake 10. 1). Luckily enough I have a third machine where I recently installed Mandrake 10.2. It ships with perl 5.8.6. And yes, it runs that nightly just fine. And just to have a little more fun I rebooted into Windows and installed 05-01. Bot the binary and run using ActivePerl 5.8.4 are fine... I don't understand what's wrong here. Anyone got an idea what's wrong here?
Created attachment 510 [details] a better fix for the search crash Ok, ok... I knew it can't be the perl version :-). It was the searchSubString setting: Buttons::Search::searchTerm() was returning a string when searching in substrings, but an array if only at the beginning of a word. Now always return an array, and we should be fine.
Thanks Michael The better fix is working like a charme from SB as from Web-GUI with 2005-05-11 @ Centos 3.4 (perl v5.8.4) Daniel
Thanks for testing! Now if only one of the officials would say something... Maybe I'll have to check this in to see some reaction ;-)
Checked in as change 3165.
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006. I am setting them to targets of 6.2.1 to keep them from showing up in my queries.