Bug 15106 - Time input in touch mode will display h-1:m-1
: Time input in touch mode will display h-1:m-1
Status: CLOSED FIXED
Product: SB Touch
Classification: Unclassified
Component: UI Input
: unspecified
: PC Other
: P1 major (vote)
: 7.5.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-12 09:27 UTC by Michael Herger
Modified: 2010-04-08 17:25 UTC (History)
3 users (show)

See Also:
Category: Bug


Attachments
UI broken for timeinput (51.56 KB, image/png)
2009-11-13 13:29 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Herger 2009-11-12 09:27:19 UTC
If I've set the alarm to fire at 09:23, entering the time input again will display 08:22 instead when using the touch interface. IR UI seems to be fine (though visually broken). Tested both 12h and 24h input. 

Interestingly the correct value seems to be highlighted using a brighter white value, but is not the active element in the time selector.
Comment 1 Michael Herger 2009-11-12 09:28:25 UTC
That's with firmware 8035.
Comment 2 Ben Klaas 2009-11-13 13:29:55 UTC
Created attachment 6302 [details]
UI broken for timeinput

I believe this was broken by the drawing optimizations made recently. If you have some suggestions on how to fix (or a fix), much appreciated.

Also note that this is the initial window for a 9:02 alarm, and it has 8:01 selected.

Probably can be fixed with some mucking with the skin. Still mine to investigate and fix.
Comment 3 SVN Bot 2009-11-13 15:01:36 UTC
 == Auto-comment from SVN commit #8102 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8102 ==

Bug: 15106
Description: skin fixes for time input on WQVGA skins
still broken on controller/baby I think
Comment 4 SVN Bot 2009-11-13 15:04:54 UTC
 == Auto-comment from SVN commit #8103 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8103 ==

Fixed Bug: 15106
Description: skin fixes for QVGA skins and timeinput assets
Comment 5 Michael Herger 2009-11-14 23:14:19 UTC
I'm sorry to say this isn't fixed here in 8105. Still exactly the same behaviour.

It looks to me as if the two changes listed here only addressed some skinning issues (as documented in the attached screenshot too), but no time value handling.
Comment 6 Ben Klaas 2009-11-16 09:23:16 UTC
adding 1 hour left...hopefully this is an easy fix (I actually confirmed the remaining issue Micheal reports to no longer be a problem, so not sure what's going on here)
Comment 7 Ben Klaas 2009-11-16 12:31:42 UTC
egads, it's only a problem on the device and not on desktop running the same skin :(
Comment 8 Ben Klaas 2009-11-16 12:33:57 UTC
confirmed as a problem on both 12h and 24h formatting on fab4. not seen at all on desktop.
Comment 9 SVN Bot 2009-11-16 13:31:59 UTC
 == Auto-comment from SVN commit #8116 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8116 ==

Fixed Bug: 15106 +1
Description:
- shift effective items before scroll only while mouse in progress
Comment 10 Ben Klaas 2009-11-16 14:17:23 UTC
fix confirmed, thanks Tom
Comment 11 Chris Owens 2010-04-08 17:25:50 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!