Matt: is this a bug, or a design feature?

This was a design decision.  Despite that, Matt Weldon, the concensus of the bug meeting is that this behavior is crazy.  Was there a good reason for it?

This may be easier to solve in XMLBrowser than I purported at the last bug meeting (sorry, I have a knee jerk reaction to XMLBrowser that it's a black hole where any change made causes other problems elsewhere; may not be the case here)

Local music does different behavior when the pref (it's a player pref) is set for playtrackalbum vs. not set. The default pref is playtrackalbum to be on, but if the user has unset this, we should honor that setting in XMLBrowse items.

we do this for local music by checking first for the player pref and then the server pref like so:

    if ( $request->client ) {
                $playalbum = $prefs->client($request->client)->get('playtrackalbum');
        }

        # if player pref for playtrack album is not set, get the old server pref.
        if ( !defined $playalbum ) {
                $playalbum = $prefs->get('playtrackalbum');
        }

if playalbum is set then the command callback is rewritten:

   if ( $playalbum && ! $partyMode ) {
                                                $actions->{'play'} = {
                                                        player => 0,
                                                        cmd    => ['jiveplaytrackalbum'],
                                                        params => {
                                                                list_index => $index + $listIndex,
                                                                folder     => $topPath,
                                                        },
                                                        nextWindow => 'nowPlaying',
                                                };
                                        }


in XMLBrowser, there is only a small section of code that handles all of this:
 if ( @urls ) {

                                        if ( main::INFOLOG && $log->is_info ) {
                                                $log->info(sprintf("Playing/adding all items:\n%s", join("\n", @urls)));
                                        }

                                        if ( $method =~ /play|load/i ) {
                                                $client->execute([ 'playlist', 'clear' ]);
                                        }

                                        my $cmd;
                                        if ($method =~ /add/) {
                                                $cmd = 'add';
                                        }
                                        else {
                                                $cmd = 'inserttracks';
                                        }

                                        my $play_index = $request->getParam('play_index') || 0;

                                        $client->execute([ 'playlist', $cmd, 'listref', \@urls ]);

                                        # if we're adding or inserting, show a showBriefly
                                        if ( $method =~ /add/ || $method eq 'insert' ) {
                                                my $icon = $request->getParam('icon');
                                                my $title = $request->getParam('favorites_title');
                                                _addingToPlaylist($client, $method, $title, $icon);
                                        # if not, we jump to the correct track in the list
                                        } else {
                                                $client->execute([ 'playlist', 'jump', $play_index ]);
                                        }
                                }

I think we just need to do a check for the pref here, format the command name correctly, and not do the playlist jump command if the user doesn't want the remaining tracks.

Andy, to you for comment, then you can send back to me. I'm ramping this up to a 7.5 P2 bug.

Agreed, I think that area of the code is the only thing that needs to change to fix this.

 == Auto-comment from SVN commit #29225 to the slim repo by bklaas ==
 == https://svn.slimdevices.com/slim?view=revision&revision=29225 ==

Fixed Bug: 15033
Description: only play one track when
Player Settings->Basic Settings->Play Other Songs in Album is set to "play only selected song"

This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!