Bug 14952 - Can't add Album as a Favorite using iPeng in 7.4.1
: Can't add Album as a Favorite using iPeng in 7.4.1
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 7.4.1
: PC Other
: P3 normal (vote)
: 7.5.x
Assigned To: Ben Klaas
: ipeng
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-27 06:59 UTC by Joerg Schwieder
Modified: 2011-01-14 09:22 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joerg Schwieder 2009-10-27 06:59:27 UTC
Adding an album as a favorite using iPeng does not work due to an redundant "undef" parameter in the SlimBrowser menu.

The Context menu I get for an album in 7.4.1 contains a "type => undef" parameter which, passed back to the server as "null" by iPeng makes the server ignore the command.

This worked in 7.4.0

Some logs:

7.4.1:

[09-10-27 10:21:01.1971] Slim::Web::Cometd::Manager::deliver_events (228) Delivering events to 0d549d2e:
[
  {
    channel => "/0d549d2e/slim/request",
    data => {
          count     => 2,
          item_loop => [
                         {
                           actions => { go => { cmd => ["jiveblankcommand"], player => 0 } },
                           nextWindow => "parent",
                           text => "Abbrechen",
                         },
                         {
                           actions => {
                                 go => {
                                         cmd => ["favorites", "add"],
                                         params => {
                                               title => "10th Anniversary (Bonus DVD)",
                                               type  => undef,
                                               url   => "db:album.titlesearch=10TH%20ANNIVERSARY%20BONUS%20DVD",
                                             },
                                         player => 0,
                                       },
                               },
                           nextWindow => "grandparent",
                           text => "Hinzuf\xFCgen 10th Anniversary (Bonus DVD)",
                         },
                       ],
          offset    => 0,
          window    => { titleStyle => "favorites" },
        },
    ext => { priority => "" },
    id => 54,
  },
]

7.4.0:

[09-10-27 14:44:01.6033] Slim::Web::Cometd::Manager::deliver_events (228) Delivering events to 34fde634:
[
  {
    channel => "/34fde634/slim/request",
    data => {
          count     => 2,
          item_loop => [
                         {
                           actions => { go => { cmd => ["jiveblankcommand"], player => 0 } },
                           nextWindow => "parent",
                           text => "Abbrechen",
                         },
                         {
                           actions => {
                                 go => {
                                         cmd => ["favorites", "add"],
                                         params => { title => "26 1/2", url => "db:album.titlesearch=26%201%202" },
                                         player => 0,
                                       },
                               },
                           nextWindow => "grandparent",
                           text => "Hinzuf\xFCgen 26 1/2",
                         },
                       ],
          offset    => 0,
          window    => { titleStyle => "favorites" },
        },
    ext => { priority => "" },
    id => 34,
  },
]
Comment 1 Chris Owens 2010-01-04 16:00:33 UTC
Changing priorities due to management guidance.
Comment 2 Joerg Schwieder 2010-03-08 03:05:15 UTC
OK, got this to work for the current track, same as here:
https://bugs-archive.lyrion.org/show_bug.cgi?id=14857

Not sure whether you made changes to this but I finally got this working by
preserving some states in my menu structure.

I see the parameters sent by SP have changed (there's now also a 
context:playlist

and 

currentTrack:1

parameter, adding these fixes the issue.

If you've done anything to fix this: thanks! :)


HOWEVER: This still doesn't work for other tracks than the curren one which probably is not an iPeng related issue since I see that the context menu on the controller for other tracks in the current playlist is very different and probably broken (it's a track info menu like for a local track and contains some nice items - like Album Review - and some broken ones - like Biography and Browse by selected).
Comment 3 Joerg Schwieder 2010-03-08 09:14:23 UTC
OK, please forget/delete my last comment, added that one to the wrong bug.

HOWEVER:
This one looks fixed to me, too, in 7.5.
Comment 4 Chris Owens 2010-03-08 11:17:24 UTC
Moving P3 and lower bugs to next release target
Comment 5 Ben Klaas 2011-01-14 09:22:53 UTC
this one appears to be okay and should have been closed a while back