Bug 14883 - audio_size needed for WAV and AIFF files.
: audio_size needed for WAV and AIFF files.
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.4.0
: PC All
: P1 normal with 2 votes (vote)
: 7.5.1
Assigned To: Andy Grundman
: Audio::Scan
Depends on:
Blocks: 14552
  Show dependency treegraph
 
Reported: 2009-10-21 09:38 UTC by Alan Young
Modified: 2010-04-29 09:22 UTC (History)
5 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2009-10-21 09:38:11 UTC
Addio::Scan is sets the file_size attribute for WAV and AIFF files. This is then used to set the SIZE tag which in turn sets the Track::audio_size attribute. With 7.3 the scanner would set the SIZE tag to length of the audio in the file, after the header and excluding any trailing tags.
Comment 1 SVN Bot 2009-10-26 05:55:23 UTC
 == Auto-comment from SVN commit #484 to the opensource repo by andy ==
 == https://svn.slimdevices.com/opensource?view=revision&revision=484 ==

Bug 14883, add audio_size info to WAV/AIFF
Comment 2 Jim McAtee 2009-10-26 13:39:17 UTC
Looks like this fixed the problem with pops at the end of WAVs.  Thanks.
Comment 3 Andy Grundman 2009-10-27 07:08:34 UTC
Fixed
Comment 4 Pascal Hibon 2009-11-03 23:12:21 UTC
I also experience plops at the end of my wave files since 7.4.x.
Since I don’t know to which bug report the error belongs to I have also documented it in bug report 14552.
Comment 5 Andy Grundman 2009-11-04 05:42:12 UTC
Try doing a full rescan with the latest 7.4.2.
Comment 6 Pascal Hibon 2009-11-04 08:46:46 UTC
I installed 7.4.2 –r29150, did a full rescan and no more plops. Thanks Andy.
Comment 7 Larry Rogers 2010-04-22 08:12:30 UTC
Trevor asked me to contact the engineers on this matter which is happening again with AIFF (but NOT Apple Lossless) files with version 7.5. The burst of static type white noise is very loud and seems that it could damage my speakers or amps.
The engineers can contact me directly by phone at 530-474-5193.
Comment 8 Andy Grundman 2010-04-22 08:20:14 UTC
Do you also have the problem with WAV files?
Comment 9 Andy Grundman 2010-04-22 08:21:23 UTC
Reopening.
Comment 10 Larry Rogers 2010-04-22 08:41:07 UTC
(In reply to comment #8)
> Do you also have the problem with WAV files?
I do not have any WAV files, Andy. 
I have about 13000 songs in AIFF
52000 in Lossless.
So far it happens with all AIFF, no matter what file they happen to be
and never does it happen with lossless
Comment 11 Andy Grundman 2010-04-22 08:42:13 UTC
OK, I'll check it out.
Comment 12 Larry Rogers 2010-04-22 08:44:25 UTC
(In reply to comment #11)
> OK, I'll check it out.
I'll be gone for a while this AM...back this afternoon.
Comment 13 Andy Grundman 2010-04-22 09:29:33 UTC
I can't reproduce this.  I tried an AIFF file with an ID3 tag at the end, audio_offset and audio_size are properly read and don't cause any pops.  I tried native AIFF as well as AIFF->FLAC.  I think I'm going to need one of your files.  Can you attach a small one that has the problem?
Comment 14 Larry Rogers 2010-04-22 12:23:44 UTC
(In reply to comment #13)
> I can't reproduce this.  I tried an AIFF file with an ID3 tag at the end,
> audio_offset and audio_size are properly read and don't cause any pops.  I
> tried native AIFF as well as AIFF->FLAC.  I think I'm going to need one of your
> files.  Can you attach a small one that has the problem?
Problem is not with the file itself, as I stated, it occurs when in the middle of changing from one song to the next...No way to tell if it is at the end of a file, at the beginning of a file or in that space in between.
None of the AIFF of mine were ever FLAC though.
Comment 15 Andy Grundman 2010-04-22 12:29:35 UTC
OK, can you send me some file(s) so I can reproduce the problem?
Comment 16 Larry Rogers 2010-04-22 14:35:04 UTC
(In reply to comment #15)
> OK, can you send me some file(s) so I can reproduce the problem?
Yes sure, I can try. How do I do it? I pulled 2 consecutive tunes off an album and have the files on my desktop. I have a Mac.
Comment 17 Andy Grundman 2010-04-22 15:08:57 UTC
You could find the smallest files you can and attach them to this bug.  Or send them to me via yousendit.com if they are too big.
Comment 18 Larry Rogers 2010-04-22 15:23:15 UTC
(In reply to comment #17)
> You could find the smallest files you can and attach them to this bug.  Or send
> them to me via yousendit.com if they are too big.
Nuts, they just spent a half hour uploading and I got a message that says
Local file uploads must not exceed 20 MB in size. 

I'll try plan b
Comment 19 Larry Rogers 2010-04-22 15:24:32 UTC
(In reply to comment #18)
> (In reply to comment #17)
> > You could find the smallest files you can and attach them to this bug.  Or send
> > them to me via yousendit.com if they are too big.
> Nuts, they just spent a half hour uploading and I got a message that says
> Local file uploads must not exceed 20 MB in size. 
> 
> I'll try plan b

I need an address to mail them to.
Comment 20 Andy Grundman 2010-04-22 15:40:05 UTC
andy@slimdevices.com
Comment 21 Larry Rogers 2010-04-22 15:44:09 UTC
(In reply to comment #20)
> andy@slimdevices.com
20 minutes of trying to get that yousendit site to work to no avail at all. My
browsers both tried to block it, The site  itself, after I finally got in, will
not allow a file pair that big, it tries to get me to pay 9 bucks, it will not
allow me to set a password. Same thing when I try to send just one at a time.
We need another way to do this.
Can I burn an album to a CD in AIFF and mail it by snail mail to you? If so I
need an address.
As you can tell I am pretty frustrated.
Whatever fix you did to 7.4 when you changed it to 7.4.2 is what worked before
when this happened. I suppose that fix does not work anymore?
As before. If you can please phone me 530-474-5193 we can quit beating around
the bush. I have a vision problem that makes reading a real chore.
Thanks
Comment 22 Andy Grundman 2010-04-22 16:34:23 UTC
I'm assigning this to QA, maybe they can reproduce it without your files.
Comment 23 Larry Rogers 2010-04-22 17:01:12 UTC
(In reply to comment #22)
> I'm assigning this to QA, maybe they can reproduce it without your files.
OK, will I be in the loop if and when the fix is (re)discovered?
Comment 24 Andy Grundman 2010-04-23 05:08:49 UTC
Larry would you be able to enable database.info debugging, do a full rescan, and post a snippet of your scanner.log that shows one or two of your broken files?  Specifically I'm looking for the AUDIO_SIZE, AUDIO_OFFSET, and FILESIZE values, it will look something like this:

[10-04-23 08:04:48.4926] Slim::Schema::_preCheckAttributes (2171) Report for file:///Users/andy/Music/Slim/wav-aiff/pre-id3.aif:
...
[10-04-23 08:04:48.4946] Slim::Schema::_preCheckAttributes (2181) .. AUDIO_SIZE : 38434040
...
[10-04-23 08:04:48.5000] Slim::Schema::_preCheckAttributes (2181) .. AUDIO_OFFSET : 2278
...
[10-04-23 08:04:48.5015] Slim::Schema::_preCheckAttributes (2181) .. FILESIZE : 38436318

This bug was caused by AUDIO_SIZE having the wrong value, and being equal to FILESIZE.  Here you can see my test file correctly sets AUDIO_SIZE to the size of the SSND chunk within the file, so no extra bytes are sent to the player when playing the file.
Comment 25 Larry Rogers 2010-04-23 07:09:25 UTC
(In reply to comment #24)
> Larry would you be able to enable database.info debugging, do a full rescan,
> and post a snippet of your scanner.log that shows one or two of your broken
> files?  Specifically I'm looking for the AUDIO_SIZE, AUDIO_OFFSET, and FILESIZE
> values, it will look something like this:
> 
> [10-04-23 08:04:48.4926] Slim::Schema::_preCheckAttributes (2171) Report for
> file:///Users/andy/Music/Slim/wav-aiff/pre-id3.aif:
> ...
> [10-04-23 08:04:48.4946] Slim::Schema::_preCheckAttributes (2181) .. AUDIO_SIZE
> : 38434040
> ...
> [10-04-23 08:04:48.5000] Slim::Schema::_preCheckAttributes (2181) ..
> AUDIO_OFFSET : 2278
> ...
> [10-04-23 08:04:48.5015] Slim::Schema::_preCheckAttributes (2181) .. FILESIZE :
> 38436318
> 
> This bug was caused by AUDIO_SIZE having the wrong value, and being equal to
> FILESIZE.  Here you can see my test file correctly sets AUDIO_SIZE to the size
> of the SSND chunk within the file, so no extra bytes are sent to the player
> when playing the file.
OK, full rescan started now. Are you asking me to play 2 songs in which this glitch happens and then send the Scanner log? Or just send the scanner log after it has done the full scan?
FWIW, I have rescanned the library several times and it has not stopped the burst of white noise/static.
Comment 26 Andy Grundman 2010-04-23 07:24:51 UTC
When it's done, open scanner.log and search for a file that has the problem, and just copy/paste the bits I mentioned.  You don't need to send the whole log.
Comment 27 Larry Rogers 2010-04-23 07:29:25 UTC
(In reply to comment #26)
> When it's done, open scanner.log and search for a file that has the problem,
> and just copy/paste the bits I mentioned.  You don't need to send the whole
> log.
OK, but I may have a hard time finding or seeing it because of my vision problem. If I cannot pick those files out I will copy the whole Scanner log and send it. The rescan will likely take some time. Will send what I can when it completes.
Comment 28 Larry Rogers 2010-04-23 10:03:52 UTC
(In reply to comment #27)
> (In reply to comment #26)
> > When it's done, open scanner.log and search for a file that has the problem,
> > and just copy/paste the bits I mentioned.  You don't need to send the whole
> > log.
> OK, but I may have a hard time finding or seeing it because of my vision
> problem. If I cannot pick those files out I will copy the whole Scanner log and
> send it. The rescan will likely take some time. Will send what I can when it
> completes.
Got this message when I tried to post the log:
Comments cannot be longer than 65,535 characters. 
My eyes will not allow me to try and read thru that immense log and try to find what you are looking for. Once again your request is is possible to achieve considering my vision impairment and the size of what you want.  I can burn the file to a CD (maybe, who knows) and snail mail it to you. Awaiting further instructions. Meanwhile a lot of my art work did not get rescanned in (yet again) so I need to try and rescan to get that back. I have saved the scan log file to my desk top, I have no other idea on how to get this to you.
Comment 29 Larry Rogers 2010-04-23 10:12:45 UTC
(In reply to comment #28)
> (In reply to comment #27)
> > (In reply to comment #26)
> > > When it's done, open scanner.log and search for a file that has the problem,
> > > and just copy/paste the bits I mentioned.  You don't need to send the whole
> > > log.
> > OK, but I may have a hard time finding or seeing it because of my vision
> > problem. If I cannot pick those files out I will copy the whole Scanner log and
> > send it. The rescan will likely take some time. Will send what I can when it
> > completes.
> Got this message when I tried to post the log:
> Comments cannot be longer than 65,535 characters. 
> My eyes will not allow me to try and read thru that immense log and try to find
> what you are looking for. Once again your request is is possible to achieve
> considering my vision impairment and the size of what you want.  I can burn the
> file to a CD (maybe, who knows) and snail mail it to you. Awaiting further
> instructions. Meanwhile a lot of my art work did not get rescanned in (yet
> again) so I need to try and rescan to get that back. I have saved the scan log
> file to my desk top, I have no other idea on how to get this to you.
OK, I tried to email the whole file...I think it got thru, let me know please.
Comment 30 Larry Rogers 2010-04-24 06:12:02 UTC
(In reply to comment #29)
> (In reply to comment #28)
> > (In reply to comment #27)
> > > (In reply to comment #26)
> > > > When it's done, open scanner.log and search for a file that has the problem,
> > > > and just copy/paste the bits I mentioned.  You don't need to send the whole
> > > > log.
> > > OK, but I may have a hard time finding or seeing it because of my vision
> > > problem. If I cannot pick those files out I will copy the whole Scanner log and
> > > send it. The rescan will likely take some time. Will send what I can when it
> > > completes.
> > Got this message when I tried to post the log:
> > Comments cannot be longer than 65,535 characters. 
> > My eyes will not allow me to try and read thru that immense log and try to find
> > what you are looking for. Once again your request is is possible to achieve
> > considering my vision impairment and the size of what you want.  I can burn the
> > file to a CD (maybe, who knows) and snail mail it to you. Awaiting further
> > instructions. Meanwhile a lot of my art work did not get rescanned in (yet
> > again) so I need to try and rescan to get that back. I have saved the scan log
> > file to my desk top, I have no other idea on how to get this to you.
> OK, I tried to email the whole file...I think it got thru, let me know please.
In addition to this problem, I am not able to scan in 3 out of a 4 CD set that is  in Itunes and in the proper location on my hard drive. I have tried 3 times to scan in these other 3 CDS and they just will not show.
Comment 31 Andy Grundman 2010-04-29 09:22:48 UTC
At this point we really need a file to test it.  I'm going to mark this fixed again, but please reopen this bug if you can upload a file that demonstrates the problem.

This wiki page has info about an anonymous FTP you can upload large files to: http://wiki.slimdevices.com/index.php/Large_File_Upload