Bugzilla – Bug 14859
Radio Power Button Bouncing
Last modified: 2009-10-21 10:36:37 UTC
Created attachment 6176 [details] Email Bouncing occurs with Radio Power Button
Created attachment 6177 [details] Video from JC
*** Bug 14755 has been marked as a duplicate of this bug. ***
Created attachment 6181 [details] Robustified button debouncing Richard, Please review this fix. It seems to be robust now. I've seen the button debouncing with mute as well, and it seems to be gone on both power and mute now. It no longer tries to play tricks with enabling and disabling the interrupts, nor with changing the sensitive edge. Basically, it works thusly: * set interrupt on falling edge. * in ISR, figure out which button was pressed, and set timer for callback in DEBOUNCE_TIME jiffies. * The button state machine runs at an interval of DEBOUNCE_TIME jiffies until the button goes back to IDLE state, at which time the state machine does not continue, and it waits for the next falling edge. * If the ISR gets a 'bounce' before the button is back in IDLE state, it does not restart the state machine timer.
Richard, please check out the attached baby_buttons.c. It's a significant change.
== Auto-comment from SVN commit #7913 to the jive repo by richard == == https://svn.slimdevices.com/jive?view=revision&revision=7913 == Bug #14859 Another try at button debouncing, from Caleb, tested and reviewed by Richard.
Chris to validate the fix
This fix works well on my known-bouncy unit.