Bug 14846 - Radio does not use correct alarm volume after playing music
: Radio does not use correct alarm volume after playing music
Status: CLOSED FIXED
Product: SB Radio
Classification: Unclassified
Component: Settings
: Include FW version in comment
: All All
: P1 major with 4 votes (vote)
: 7.4.1
Assigned To: Wadzinski Tom
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-19 17:14 UTC by Peter Watkins
Modified: 2009-10-22 11:23 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
patch for Ben's review (3.29 KB, patch)
2009-10-20 09:27 UTC, Wadzinski Tom
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Watkins 2009-10-19 17:14:11 UTC
SBS 7.4 tunk @ SVN 28939, Radio at 7.4.1 r7866

- Radio was silent
- created an alarm on Radio, set the volume to 40 with web UI
- set Radio volume to about 15
- played music on Radio, set volume to 20
- turned off Radio (off mode)
- wait for alarm

When the alarm fired, it was at volume 20

I was subscribing to "alarm" and "mixer" CLI events and saw no mixer events when the alarm sounded.
Comment 1 VolkerOth 2009-10-20 01:28:40 UTC
I can't even set the volume to 40 in the MySqueezebox.com web GUI for the Radio and SB3. It only offers my values between 1 and 11 which are obviously scaled up in a way, but this is pretty strange (if at all you would expect 0..10), unpredictable and also too coarse.
Comment 2 Ben Klaas 2009-10-20 08:39:25 UTC
Looks to be a problem where SP-side is getting erroneously "out of sequence" with the server after soft power off, so when alarm hits the out of sequence code kicks in and resets the local volume to what it was previously, rather than accepting the alarm volume setting.

Tom and I both agree this bug is bad enough to hold up 7.4.1 release.
Comment 3 Wadzinski Tom 2009-10-20 09:27:11 UTC
Created attachment 6175 [details]
patch for Ben's review
Comment 4 Wadzinski Tom 2009-10-20 09:29:20 UTC
Assigned to Ben for review. -- Power commands coming from the server were being looped back to the server, causing a temp player state out of sync state. Fix is to not update the sequence number and not loop the power command back to the server.
Comment 5 Ben Klaas 2009-10-20 09:46:20 UTC
patch has my blessing. recommend checking it into 7.4/trunk
Comment 6 SVN Bot 2009-10-20 09:47:00 UTC
 == Auto-comment from SVN commit #7907 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7907 ==

Fixed Bug: 14846
Description:
- don't loopback power commands that came from server.
Comment 7 James Richardson 2009-10-22 11:23:27 UTC
This bug has been marked as fixed in the 7.4.1 release version of SqueezeBox
Server! 

Please see the Release Notes for all the details:
http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from
http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with
your new comments and we'll have another look.