Bug 1483 – if current playlist spans multiple pages, current song is not on first page, it doesn't load the proper page

Bug 1483 - if current playlist spans multiple pages, current song is not on first page, it doesn't load the proper page

Summary:

if current playlist spans multiple pages, current song is not on first page, ...

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.1.0
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-05-02 10:29 UTC by Kevin Pearsall
Modified:	2008-09-15 14:37 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
stay with current song even on multiple pages (1.18 KB, patch) 2005-05-10 19:18 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kevin Pearsall 2005-05-02 10:29:06 UTC

Not sure how else to put this.

If you queue up a lot of songs (several hundred), then skip to a song that's a
few pages in to the current playlist (using the default skin), it will say Now
Playing: X song, when X song does not appear on the current page, it's on one of
the successive pages...  but the server isn't showing the right page of the
playlist, only the first one.

Comment 1 Greg Klanderman 2005-05-09 08:21:44 UTC

yep, I noticed this the other day.

Comment 2 KDF 2005-05-10 11:59:41 UTC

I think this relates to change 2530.  The pageBar uses an undef or blank
$params->{'start'} to indicate that we might have to figure out on which page
the current song resides.  Defaulting to zero, as done in change 2530, then
pageBar assumes that a web link as instructed the playlist to render from page 0.

Comment 3 KDF 2005-05-10 19:18:14 UTC

Created attachment 512 [details]
stay with current song even on multiple pages

instead of defaulting $params->{'start'} to 0, use the check from pageBar to
quickly get the proper start value.  matching pages then will still follow the
playlist render cache optimisations.

also works for bug 1241

Comment 4 KDF 2005-05-10 23:34:44 UTC

committed to 6.1 in change 3153
committed to 6.0.3 branch at change 3154

Comment 5 Chris Owens 2006-06-16 14:41:14 UTC

There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.