Bug 14774 - Preamp Volume Control is not working anymore
: Preamp Volume Control is not working anymore
Status: CLOSED FIXED
Product: SB Receiver
Classification: Unclassified
Component: General
: 65
: PC Other
: P2 normal with 3 votes (vote)
: 7.5.0
Assigned To: Mikael Nyberg
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-14 13:55 UTC by Mikael Nyberg
Modified: 2010-04-08 17:26 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
untested patch that should fix the UI problem (386 bytes, patch)
2009-11-03 20:06 UTC, Peter Watkins
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Nyberg 2009-10-14 13:55:37 UTC
See the tread:

http://forums.slimdevices.com/showthread.php?p=471929#post471929

Actually I don't know when it stopped working.
I filed it a reciever fw problem, can also be sbs problem.
The preamp volume setting 0-63 does nothing at all anymore.
Comment 1 Chris Owens 2009-10-19 09:46:57 UTC
QA to research when this became broken, and judge whether it is important.
Comment 2 James Richardson 2009-10-30 12:05:53 UTC
Mikael: can I assign this one back to you for investigation?  QA unable to dedicate the time to investigate this issue.
Comment 3 Mikael Nyberg 2009-11-02 20:49:05 UTC
"Mikael: can I assign this one back to you for investigation?  QA unable to
dedicate the time to investigate this issue."

Duh ? what do I do with this, I have no programming skills .
I don't have multiple versions of the server running, so to investigate when it broke I need at least an 7.2 and one 7.3 server, for initial test.
To figure if it broke before 7.2 or after 7.3 .

I can do this smal thing:

1. Try with the latest 7.5 to see if still a problem
2. Try on my SB3 . To see if it is an receiver only problem

If any of the other subscribers to this bug has any clue on which version you where on the last time you knew it worked fine ?
Please report here.
Comment 4 Mikael Nyberg 2009-11-02 21:10:30 UTC
I made this post in the forum tread , maybe we can collect some data there:

"
There has been little or or no progress regarding this issue.

Moore information is needed

And post it to this bug: https://bugs-archive.lyrion.org/show_bug.cgi?id=14774

1. Which was the latest known version of ss/sc/sbs you *knew* this was working on ? nobody knows when it broke.

2. Does this affect your SB3 or SB2 too, or only the Receiver.

3. If you are using this function, try to change your settings, this could tell interesting things.
Does the sb retains old settings done with older ss/sc/sbs ?
Can you change it ?
Did it broke when you tried ;-) ?
This is a value you set once in every system you don't need to change it unless you change the setup with a new amp or new speakers (or new room ).
It might well be that if you set this value with an old ss and have not done factory reset on the player, it still retains this setting ?
This could explain why very few sees this problem.

Nobody has figured if it is a ss/sc/sbs problem or player firmware problem ?


Anyone with an old version running could test too, maybe we can find a data point for when it broke.
"
Comment 5 Peter Watkins 2009-11-03 19:54:25 UTC
See http://forums.slimdevices.com/showpost.php?p=481366&postcount=13

Sean Adams writes "I believe it was an oversight that this setting is exposed at all on Receiver. It's specific to SB2 and SB3 (which had a digital attenuation feature in the DAC, separate from the main volume control)."
Comment 6 Peter Watkins 2009-11-03 20:06:44 UTC
Created attachment 6269 [details]
untested patch that should fix the UI problem

modify the Receiver class to indicate that SBR does not support preamp gain; should work with Slim/Web/Settings/Player/Audio.pm and HTML/EN/settings/player/audio.html to hide this setting for SBR players
Comment 7 Felix Mueller 2009-11-05 04:03:10 UTC
Thanks Mikael and Peter. I am pretty sure Sean is correct with his observation. I've tested the patch and it hides the setting for Receivers just fine.
Comment 8 SVN Bot 2009-11-05 04:06:36 UTC
 == Auto-comment from SVN commit #29166 to the slim repo by felix ==
 == https://svn.slimdevices.com/slim?view=revision&revision=29166 ==

Bug: 14774 
Description: Remove 'Preamp Volume Control' setting for SBR.
Comment 9 Chris Owens 2010-04-08 17:26:51 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!