Bug 1475 - disabled itunes tracks require wipe cache to re-enable
: disabled itunes tracks require wipe cache to re-enable
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: iTunes
: 6.1.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-30 20:40 UTC by howard mahran
Modified: 2008-09-15 14:36 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
check disabled before mtime (1.00 KB, patch)
2005-05-05 12:46 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description howard mahran 2005-04-30 20:40:15 UTC
Unchecked itunes songs are *not* ignored when "ignore itunes unchecked" is 
selected in server settings
Comment 1 KDF 2005-04-30 20:45:15 UTC
that's what this does:
			# skip track if Disabled in iTunes
			if ($curTrack{'Disabled'} &&
Slim::Utils::Prefs::get('ignoredisableditunestracks')) {

				$::d_itunes && msg("iTunes: deleting disabled track $url\n");

				$ds->markEntryAsInvalid($url);

				return 1;
			}


are you using a music folder? or other data sources? do you see that message in
the d_itunes debug log?
Comment 2 KDF 2005-05-05 12:28:34 UTC
Vidur, are you able to reproduce this?
Comment 3 KDF 2005-05-05 12:42:09 UTC
it seems that change 2642 is responsible, which means change 2673 has no effect
on reload.  It will only work on a wipe cache.  'm testing out a patch, will
attach shortly if it works.
Comment 4 KDF 2005-05-05 12:46:11 UTC
Created attachment 489 [details]
check disabled before mtime

This checks for disabled tracks before we skip the file due to mtime.  However,
since iTunes doesn't update its mod time NOR the files when disabling or
enabling, this only works ONE WAY.  This allows a disable, but the tracks will
not come back if you just enable.  It requires a wipe cache :(	iTunes...is
annoying.
Comment 5 Bruce Norman 2005-05-22 22:32:34 UTC
A major problem for me - please resolve ASAP
Comment 6 Vidur Apparao 2005-05-23 12:23:26 UTC
KDF, if the patch works for you, please commit to trunk and branch. Thanks!
Comment 7 KDF 2005-05-23 23:51:50 UTC
as per comment, it does not work.  it is unidrectional.  disabling works, but
re-enabling a track will require a wipe cache.

I can commit the fix, but this bug will have to remina open, perhaps retitled.
Comment 8 KDF 2005-05-24 00:01:22 UTC
committed fix to 6.1 at change 3282, retitling as mentioned.
Comment 9 Blackketter Dean 2005-06-07 16:26:47 UTC
Howard (et. al.) can you try the latest 6.1 nightly release and verify that the bug is fixed.  Reopen if you 
are still having issues.
Comment 10 KDF 2005-06-07 16:33:32 UTC
this is still an issue as titled.  the only resolved part (change 3282) was to
allow disabling.  IF you then use iTunes and uncheck, or change the setting in
the server prefs, the files are still deleted until you wipe cache.

Dan informed me that the mtime info in iTunes was supposedly fixed in 4.8, but
the disable/enable setting seems to have no effect on mtime, thus the
optimisations in the iTunes scan still skip disabled files.
Comment 11 Vidur Apparao 2005-06-30 15:06:36 UTC
This doesn't look like it's going to make it for 6.1.
Comment 12 KDF 2005-08-10 12:18:21 UTC
This seems to be working as of Aug 10 6.2 nightly, svn change 3912.

please confirm.  re-open if necessary.