Bugzilla – Bug 14710
Do not migrate SC server/plugins prefs on SBS server removal/upgrade but on first SBS installation
Last modified: 2011-02-06 23:45:25 UTC
I had a look at the SBS addon's scripts, and couldn't help notice some stuff added to the remove.sh script to migrate preferences, and probably related to bug #13327. Most of this stuff would have been better located in the install.sh script, IMHO. My understanding of the script, and the way it goes on ReadyNAS is: 1. When users upgrade from SqueezeCenter 7.3 to Squeezebox Server 7.4, all the server and plugins preferences are lost, because there's nothing done in the install.sh script to handle this migration, 2. Users have to set up Squeezebox Server to their taste, and maybe have changed their mind on preferences that were used previously with SqueezeCenter, 3. One day, they have to install (or reinstall) the SBS addon, and the installed remove.sh script (aka SLIMSERVER.remove) will be called and will overwrite the actual SBS server/plugins prefs with the older SC ones. 4. User will have to adjust his/her settings again
Michael: your thoughts on this?
Created attachment 6079 [details] Proposed patch to install.sh and remove.sh files Attached is a patch for the install.sh and remove.sh scripts: - Removed all code pertaining to old services removal in remove.sh - Added some code for trying to migrate server and plugins preferences from SlimServer and/or SqueezeCenter when one of those is currently used at install time, and removing all files from these services once the Squeezebox Server installation is done. I also corrected the install.sh script so that it stops the good service (it wouldn't properly stop SlimServer/SqueezeCenter when upgrading from these, due to the init script name change). I ran out of time for building my own addon binary file, and testing it exhaustively. So, be warned it has only been roughly tested on my NV+, by faking presence of SlimServer/SqueezeCenter installations, and commenting lines or just echoing actions I didn't want the install.sh script to really do. So far, it looks like it's doing things as intended, but more serious testing is required... I hope this'll help. P.S.: even if you don't care with the migration process, the "stop" command patch in install.sh is a must have...
Moving these bugs to P4 to make room for moving P1.5 bugs to P2
Administrative move of 7.5 bugs. All P2, P3, P4 being downgraded one level. Will then split P1s.
Moving P3 and lower bugs to next release target
Hmm... is this still an issue?
I guess all ReadyNAS users already have upgraded to SBS 7.4 at least, and probably got into trouble step #3. As Edith Piaf sang: "Avant l'heure, c'est pas l'heure, après l'heure, c'est plus l'heure".
Thanks for the following up. I love musical quotes :-).