Bug 1465 – worldclock.pm fails to compile when using slim.exe but not using activestate

Bug 1465 - worldclock.pm fails to compile when using slim.exe but not using activestate

Summary:

worldclock.pm fails to compile when using slim.exe but not using activestate

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Windows Service
Version:	6.1.0
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-04-28 15:37 UTC by Kevin Pearsall
Modified:	2009-09-08 09:15 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kevin Pearsall 2005-04-28 15:37:56 UTC

customer reported.

fails on compilation at line 51 which is:
use Time::localtime;

is something missing from the compiled slim.exe?

Comment 1 KDF 2005-04-28 15:45:16 UTC

many CPAN modules are not included, linke Time::localtime. Plugins can sometimes
require modules that are not included with slimserver, such as Net::POP3 etc. 
Users have to install them manually unless they have the modules as part of
their perl environment (activestate probably includes this module in their
install).  Plugin authors may also include these modules as part of their plugin
package.

eg.  rename Worldclock.pm to WorldClock/Plugin.pm, and add localtime.pm to
WorldClock/localtime.pm..

or the user can copy Time/localtime.pm from their active state install, and copy
it to Plugins/Time/localtime.pm (i believe that should work). 

not really a bug.

Comment 2 Felix Mueller 2005-06-15 00:48:56 UTC

I just stumbled over this problem. What can I do to make it easier for people to
run WorldClock? Is it sufficiant to provide the localtime.pm I have on my SuSE
system for people to copy to Plugins/Time/localtime.pm? Would that work for
people on different platforms?

Comment 3 Blackketter Dean 2005-06-15 06:52:41 UTC

Felix: including localtime would be the safest thing to do.  Alternatively we could force localtime to be 
included with the slim.exe distribution.  Dan?

Comment 4 Blackketter Dean 2005-06-15 06:53:00 UTC

Dan, what do you think?

Comment 5 Dan Sully 2005-08-30 11:39:59 UTC

We can include Time::localtime - or Felix can change his code to use the built in localtime(), which 
Time::localtime is simply a wrapper around.

Comment 6 Dan Sully 2005-08-31 08:24:34 UTC

Added modules in subversion change 4133