Bugzilla – Bug 14528
Bug in AppletManager._evalMetas
Last modified: 2010-04-08 17:24:30 UTC
In the first loop _evalMetas tries to configure all Applets. If one applet has an error while configuring, an error is logged and the method returns: -- line 368 -- log:error("Error configuring meta for ", entry.appletName, ":", resOrErr) return nil --- I think it is wrong to leave the method, because all subsequent Applets won't be configured. This can lead to all sorts of disfunction (missing screensafers for instance). I'd delete the 'return nil' line.
moving current p2 bugs to p3 to make room for moving p1.5 bugs to p2
Um, this is a oneliner. What was the result of the bug_meeting ?
Administrative move of 7.5 bugs. All P2, P3, P4 being downgraded one level. Will then split P1s.
Stefan, apologies I know this bug has been open forever. I inherited it a couple months ago when our resources were shuffled. On the surface this bug seems very trivial, but I'd like to be able to confirm that this change doesn't result in bad side effects. My issue is that I don't get how to create the error condition to test. I've intentionally injected errors into a applet's meta file, but this results in a failure to load much earlier than _evalMetas(). If you can give me some guidance with that, it would be much appreciated.
Created attachment 6573 [details] Malicious Applet
Ben the attached 'AAAApplet' throws an error in 'configureApplet()' which in turn makes the loop in _evalMetas() stop. This leads to a mostly unusable SqueezePlay (yeah - destroyed ! :) ) For instance you can't configure any screenshots anymore, wallpapers are gone and I don't know what other stuff is broken.
== Auto-comment from SVN commit #8594 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=8594 == Fixed Bug: 14528 Description: don't give up on configuring other applets after hitting an error in a different applet's meta file
Thanks Stefan- I had tried manufacturing an error in a meta file by just adding a syntax error, but to reproduce the failure it was necessary to do e.g., a non-existent function call. That is, syntactically correct, but wrong. It only took 4 months, but the one liner is checked in :-/
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release. If you are still seeing this issue, please let us know!