Bug 14484 - Up & Down keys On SqueezePlay on WinXP
: Up & Down keys On SqueezePlay on WinXP
Status: CLOSED FIXED
Product: SB Desktop
Classification: Unclassified
Component: UI
: unspecified
: PC Windows XP
: -- normal (vote)
: 7.5.0
Assigned To: Wadzinski Tom
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-01 09:52 UTC by Louis Rossouw
Modified: 2010-04-08 17:26 UTC (History)
8 users (show)

See Also:
Category: Bug


Attachments
allow up/down with numlock (524 bytes, patch)
2009-10-16 14:21 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Louis Rossouw 2009-10-01 09:52:54 UTC
Up & Down arrows dont work on keyboard on software version of SqueezePlay.
Left & Right work fine.  Mouse scroll wheel works for up and down.
Comment 1 James Richardson 2009-10-07 10:39:34 UTC
Which version of SP Desktop were you using?

Please download the latest version based on the version of SBS you have installed.

If you still see the issue, feel free to reopen the bug.
Comment 2 Louis Rossouw 2009-10-08 01:06:18 UTC
Downloaded the current version (on a different PC too) and tried it. Same problem.

It doesn't really matter what version SBS is as this is a problem whether I'm connected to a server or not.

Where does Squeezeplay store its preferences so I can reset them?
Comment 3 Louis Rossouw 2009-10-08 01:11:20 UTC
Uninstalled SqueezePlay
Deleted files in C:\Documents and Settings\User\Application Data\SqueezePlay
Reinstalled.

Same problem.  Just tested in the setup screens as I'm not at home.
Comment 4 Louis Rossouw 2009-10-08 02:26:33 UTC
oops forgot to reopen the bug.  Based on comments above.
Comment 5 Louis Rossouw 2009-10-08 02:35:28 UTC
Sorry for spamming, but I discovered the actual problem. Very strange.  I always set my number pad on the far right to numbers (via num lock) so that I type numbers with them.  I use the cursor pad to the left of them for by general cursor usage.  

In all programs I use these keys are always responding as cursor keys no-matter the state of num lock.  It seems that SqueezePlay doesn't respond to the cursor pad up and down when the number pad has been toggled with num-lock.  If I deselect num-lock it works.  Still a bug, but should be that SqeezePlay responds incorrectly to num-lock but only for up and down! :)
Comment 6 James Richardson 2009-10-08 13:39:46 UTC
Thank you for the update.  I need to know what System you have, as well as the Keyboard.

I have tested here with IBM / Apple Laptop(s) an Logitech keyboards.  Still working for me.

I suspect it's going to be specific to an OS + Hardware combo that we need to investigate.
Comment 7 Louis Rossouw 2009-10-08 18:20:40 UTC
Hi

I have the same problem on two systems:
a) Desktop
- XP patched and updated
- Gigabyte motherboard
- Keyboard is Logitech (USB connected): http://www.logitech.com/index.cfm/keyboards/keyboard/devices/4740&cl=roeu,en
- Fairly recent drivers

b) Laptop
- Dell Latitude D620
- XP 
- Keyboard is Compaq, no model no, looks like any other grey keyboard.  Connected via keyboard plug (i.e. not USB)

I assume you did test with num-lock in various positions specifically on the dedicated cursor keys and not the cursor keys that appear on the number pad.

On the Laptop I had yesterday's SqueezePlay.  On the desktop I had SqueezePlay downloaded just after 7.4 got released.

Cheers
Louis
Comment 8 James Richardson 2009-10-09 09:17:46 UTC
Lets try clearing your pref file then;  https://wiki.slimdevices.com/index.php/SqueezePlay

go there, look for the location of the pref file for your OS, clear it, then launch Squeezeplay Desktop again.
Comment 9 James Richardson 2009-10-09 09:21:42 UTC
Louis: forget the last message, I was finally able to reproduce it.  Assigning to Tom for resolution.
Comment 10 jer_gladiator 2009-10-10 04:22:39 UTC
I have the same issue on windows vista, with Logitech media keyboard elite

Could this issue be fixed before the 8.0 version, it was working normaly on previous version (7.3.x) but 7.4 introduce lots of bug :(
Comment 11 Jim McAtee 2009-10-14 15:12:38 UTC
I see the same problem on Windows XP Pro using an old Microsoft keyboard.  When NumLock is on the up and down cursor keys are not recognized.  I'm also of the opinion that this needs to be targeted for a 7.4.x release.
Comment 12 Jim McAtee 2009-10-16 12:04:15 UTC
KDF, care to take a crack at this one? :-)  It may also be Windows only.
Comment 13 KDF 2009-10-16 13:14:04 UTC
from what I can see so far, the key events are buried in SDL.  I've gotten as far as jive_framework.c for the keymap and interestingly, there is no UP or DOWN key mapping.  Hoping this is a red flag rather than wild goose.  Don't know if I'm on the right track as I cannot get any debug output to show up yet, even when numlock is off and there ARE responses to the keys.
Comment 14 KDF 2009-10-16 14:21:42 UTC
Created attachment 6141 [details]
allow up/down with numlock

ok, not a windows thing, it's purely the numlock thing.  The code ONLY accepts up/down with a modifier of 0.  This means, when numlock is on, up and down are ignored.  The fix is simple, but perhaps there is more to do if you want to, for example, use the keys on the number pad when numlock is off for scrolling.  

I've attached the patch for a basic fix, but it may not even be a bug if this is truly the intended design.
Comment 15 Louis Rossouw 2009-10-18 02:23:43 UTC
(In reply to comment #14)
> Created an attachment (id=6141) [details]
> allow up/down with numlock
> 
> ok, not a windows thing, it's purely the numlock thing.  The code ONLY accepts
> up/down with a modifier of 0.  This means, when numlock is on, up and down are
> ignored.  The fix is simple, but perhaps there is more to do if you want to,
> for example, use the keys on the number pad when numlock is off for scrolling.  
> 
> I've attached the patch for a basic fix, but it may not even be a bug if this
> is truly the intended design.

This is surely a bug, because you can't have different behaviour of num lock on left and right and up and down keys.  Also on my laptop keyboard there is only one cursor pad and this doesn't work for up and down.
Comment 16 Jim McAtee 2009-10-21 12:10:15 UTC
Can we get a checkin of this fix?  While there's no real target for SqueezePlay (apart from the mythical 8.0), someone must realize there's a huge demand for a desktop player.  Getting a few of the basic bugs out of the way so folks can better use the SP nightlies would be a big step.
Comment 17 KDF 2009-10-28 17:28:51 UTC
Have been awaiting feedback/direction, but that seems to remain at the usual non-existent levels (I assume, for anything targetted outside of the immediate future).

Tried to commit to 7.5 but fails with 403 forbidden error.  Will try again later in case it's just svn being down.
Comment 18 SVN Bot 2009-11-03 15:14:44 UTC
 == Auto-comment from SVN commit #8005 to the jive repo by kdf ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8005 ==

Bug: 14484
Description: allow arrow keys with num lock modifier on to control up/down actions.
Comment 19 KDF 2009-11-03 15:20:05 UTC
fixed for 7.5.x only.  Please reopen if there are any issues.
Comment 20 Chris Owens 2010-04-08 17:26:33 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!